Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add rootfs-image.version to fix device display #72

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

joelguittet
Copy link
Owner

The purpose of this Pull-Request is to fix the "Current software" display on mender interface. This issue was reported at #69

@joelguittet joelguittet added the bug Something isn't working label Jul 17, 2024
@joelguittet joelguittet self-assigned this Jul 17, 2024
Copy link

sonarcloud bot commented Jul 17, 2024

@joelguittet
Copy link
Owner Author

@lluiscampos if you want to check it before I merge the fix, here it is! As discussed in the issue, this is a quick fix to ensure the display of the software version. Not sure if this make sense to separate version and artifact_name, neither to add rootfs checksum ? What is your opinion ?

Note: on MCU the checksum of the image is changing when the image is validated by the bootloader. This is why I say it has not a good value to be reported.

Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lluiscampos
Copy link
Contributor

@lluiscampos if you want to check it before I merge the fix, here it is! As discussed in the issue, this is a quick fix to ensure the display of the software version

Taking into account the MCU client capabilities, this is good enough.

Not sure if this make sense to separate version and artifact_name, neither to add rootfs checksum ? What is your opinion ?

It is harmless as it is, but artifact_name could be removed in order to save few bytes.

The checksum does not make sense as long as the MCU client does not support provides/depends (iow deployments v2 POST deployments/next), where the checksum together with other attributes could be used for the server to select one or other Artifact.

Note: on MCU the checksum of the image is changing when the image is validated by the bootloader. This is why I say it has not a good value to be reported.

This is a details that I didn't know! Thanks for pointing it out.

@joelguittet
Copy link
Owner Author

Thanks for looking at this @lluiscampos ! yes it will always be possible to enhance later if required to separate artifact name and software version :-)

The point about the checksum is because of the confirmation of the image done when the update is validated. Flag set at this moment in the trailer of the slot. This is an important point when thinking to delta update, something I have already think about and I would like to propose solutions ;-) or maybe mender will do it !

@joelguittet joelguittet merged commit 435da4c into master Jul 24, 2024
5 checks passed
@joelguittet joelguittet deleted the fix/inventory-add-rootfs-version branch July 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants