-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boostrap update to v3.3.7 too address security vulnerability with JQuery #533
base: master
Are you sure you want to change the base?
Conversation
Hello, could I please have a timeframe on when this could be completed? |
Hello, just adding the 4.6 files without using them in the existing code will not help you at all in fixing the security issue. Therefore this will not be merged. But if you find time to rewrite the entire UI to use Bootstrap 4 i am happy to help/test/merge when it is done. |
Good morning, thank you for the notice. Unfortunately I'm not a UI developer. I tried making some changes and it just made the UI worst. We do still need to address the security vulnerability so any help you could provide will be greatly appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scaled the upgrade back to v3.3.7 and attached allt he changes I was able to make.
Thanks, but switching to 3.3.7 is also a lot of work, way to much changed in bootstrap. I started doing it a longer time ago but did not found the time to finish it. Lots of open points there sseide/redis-commander - bootstrap3. So other fixes on top of yours can be found there probably too. But AFAIK there is no one having time for it at the moment. And looking at the time it needs to go from Bootstrap 2 to 3 and than going to 4 is needed sooner or later too - I am not sure if it is good time spend and not better to go directly to 4... |
Hi @sseide , I am checking for an update on this issue. |
Good morning @sseide , is there any available update on this request? We have some security vulnerabilities pending for the JQuery version and are looking for a timeline for the bootstrap update. Also I see on dockerhub the latest tag was published 3 yrs ago (https://hub.docker.com/r/rediscommander/redis-commander/tags). Is this accurate? |
you are right about dockerhub - and it is mentioned right on top of the Readme:
As there is no access to docker hub for automatic releases they are not published anymore. And for Bootstrap update - no time for a complete UI rewrite yet and no timeline. But - as mentioned - help welcome |
This is to fix issue 528