Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boostrap update to v3.3.7 too address security vulnerability with JQuery #533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carellevbt
Copy link
Contributor

This is to fix issue 528

@carellevbt
Copy link
Contributor Author

Hello, could I please have a timeframe on when this could be completed?

@sseide
Copy link
Collaborator

sseide commented Jul 27, 2023

Hello,

just adding the 4.6 files without using them in the existing code will not help you at all in fixing the security issue.
With your patch the existing code will uses the older 2.3 files as current version does and does not change anything at all...

Therefore this will not be merged. But if you find time to rewrite the entire UI to use Bootstrap 4 i am happy to help/test/merge when it is done.

@carellevbt
Copy link
Contributor Author

Good morning, thank you for the notice. Unfortunately I'm not a UI developer. I tried making some changes and it just made the UI worst. We do still need to address the security vulnerability so any help you could provide will be greatly appreciated.

Copy link
Contributor Author

@carellevbt carellevbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scaled the upgrade back to v3.3.7 and attached allt he changes I was able to make.

@carellevbt carellevbt changed the title boostrap update to v4.6 too address security vulnerability with JQuery boostrap update to v3.3.7 too address security vulnerability with JQuery Aug 3, 2023
@sseide
Copy link
Collaborator

sseide commented Aug 3, 2023

Thanks, but switching to 3.3.7 is also a lot of work, way to much changed in bootstrap. I started doing it a longer time ago but did not found the time to finish it. Lots of open points there sseide/redis-commander - bootstrap3. So other fixes on top of yours can be found there probably too.

But AFAIK there is no one having time for it at the moment. And looking at the time it needs to go from Bootstrap 2 to 3 and than going to 4 is needed sooner or later too - I am not sure if it is good time spend and not better to go directly to 4...
But i will definitely approve an update to 3 as soon as it is ready to replace 2 if someone else find the time...

@carellevbt
Copy link
Contributor Author

Hi @sseide , I am checking for an update on this issue.

@carellevbt
Copy link
Contributor Author

Good morning @sseide , is there any available update on this request? We have some security vulnerabilities pending for the JQuery version and are looking for a timeline for the bootstrap update.

Also I see on dockerhub the latest tag was published 3 yrs ago (https://hub.docker.com/r/rediscommander/redis-commander/tags). Is this accurate?

@sseide
Copy link
Collaborator

sseide commented Apr 18, 2024

you are right about dockerhub - and it is mentioned right on top of the Readme:

Or run Redis Commander as Docker image ghcr.io/joeferner/redis-commander (instructions see below).

Multi-Arch images built are available at ghcr.io/joeferner/redis-commander:latest.

Remark: new version are not published to Dockerhub right now.

As there is no access to docker hub for automatic releases they are not published anymore.

And for Bootstrap update - no time for a complete UI rewrite yet and no timeline. But - as mentioned - help welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants