Adds support for combining manual and autotagging #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes logic for inferring AdWords parameters to only fill empty parameters and not overwrite any values with blanks * Changes double quotes to single quotes
|
I was finding that my manually tagged campaign names weren't coming through for AdWords campaigns. It turns out that they were being overwritten by the logic for handling autotagging, which appears to have been written with the assumption that manual and auto-tagging would not be used together. Combining both forms of tagging is something I find to be pretty common and happened to be the case for this client. There's no advantage to the former logic over this updated approach, so I think it should be good to go for a merge. Please let me know if you have any concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameters and not overwrite any values with blanks