Make model store a bit more readable. I think?

jmchilton · Jan 24, 2024 · f828a4e · f828a4e
1 parent 79f67fd
commit f828a4e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/galaxy/model/store/__init__.py b/lib/galaxy/model/store/__init__.py
@@ -1931,7 +1931,10 @@ def add(src, dest):
                 as_dict["extra_files_path"] = extra_files_path
             return
 
-        if file_name:
+        have_file_path_on_disk = bool(file_name)
+        have_extra_files_path_on_disk = bool(extra_files_path)
+
+        if have_file_path_on_disk:
             if not os.path.exists(dir_path):
                 os.makedirs(dir_path)
 
@@ -1943,7 +1946,7 @@ def add(src, dest):
             add(src, dest)
             as_dict["file_name"] = arcname
 
-        if extra_files_path:
+        if have_extra_files_path_on_disk:
             try:
                 file_list = os.listdir(extra_files_path)
             except OSError: