Skip to content

Commit

Permalink
Does this fix the typing in object stores.
Browse files Browse the repository at this point in the history
  • Loading branch information
jmchilton committed May 8, 2024
1 parent 5ee069c commit 74fcc8c
Showing 1 changed file with 18 additions and 5 deletions.
23 changes: 18 additions & 5 deletions lib/galaxy/objectstore/caching.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ class UsesCache:
staging_path: str
extra_dirs: Dict[str, str]
config: Any
cache_updated_data: bool

def _construct_path(
self,
Expand Down Expand Up @@ -505,12 +506,24 @@ def _start_cache_monitor_if_needed(self):
if self.enable_cache_monitor:
self.cache_monitor = InProcessCacheMonitor(self.cache_target, self.cache_monitor_interval)

def _get_remote_size(self, rel_path: str) -> int: ...
def _get_remote_size(self, rel_path: str) -> int:
raise NotImplementedError()

def _exists_remotely(self, rel_path: str) -> bool: ...
def _exists_remotely(self, rel_path: str) -> bool:
raise NotImplementedError()

def _push_to_os(self, rel_path, source_file: Optional[str] = None, from_string: Optional[str] = None) -> None: ...
def _push_to_os(self, rel_path, source_file: Optional[str] = None, from_string: Optional[str] = None) -> None:
raise NotImplementedError()

def _get_object_id(self, obj: Any) -> str: ...
# def _get_object_id(self, obj: Any) -> str:
# raise NotImplementedError()

def _download(self, rel_path: str) -> bool: ...
def _download(self, rel_path: str) -> bool:
raise NotImplementedError()

# Do not need to override these if instead replacing _delete
def _delete_existing_remote(self, rel_path) -> bool:
raise NotImplementedError()

def _delete_remote_all(self, rel_path) -> bool:
raise NotImplementedError()

0 comments on commit 74fcc8c

Please sign in to comment.