Merge pull request #118 from jmboehm/fix-yesnolabel

fix p nan bug, bump fixedeffectmodels to 1.7

Project.toml

@@ -1,7 +1,7 @@
 name = "RegressionTables"
 uuid = "d519eb52-b820-54da-95a6-98e1306fdade"
 authors = ["Johannes Boehm <[email protected]>"]
-version = "0.5.6"
+version = "0.5.7"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
@@ -17,7 +17,7 @@ UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
 [compat]
 Compat = "2, 3"
 Distributions = "0.21, 0.23, 0.24, 0.25"
-FixedEffectModels = "0.10, 0.11, 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6"
+FixedEffectModels = "0.10, 0.11, 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7"
 Formatting = "0.4"
 GLM = "1.3, 1.4"
 StatsBase = "0.32, 0.33"

src/decorations/default_decorations.jl

@@ -2,7 +2,7 @@ function make_estim_decorator(breaks=[0.01, 0.05, 0.1], sym='*'; wrapper=identit
   @assert issorted(breaks)
 
   function estim_decorator(s, pval)
-    pval >= 0 || @error "p value = $pval, but it needs to be non-negative"
+    (pval >= 0 || isnan(pval)) || @error "p value = $pval, but it needs to be non-negative"
 
     i0 = findfirst(pval .<= breaks)
     i = isnothing(i0) ? length(breaks) + 1 : i0