add link to UI

jloleysens · Apr 14, 2022 · cd13819 · cd13819
1 parent 1b7c5fb
commit cd13819
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 17 deletions.
diff --git a/x-pack/plugins/reporting/public/management/components/i18n_texts.tsx b/x-pack/plugins/reporting/public/management/components/i18n_texts.tsx
@@ -15,13 +15,13 @@ export const i18nTexts = {
     insufficientMemoryError: (helpUrl: string) => (
       <FormattedMessage
         id="xpack.reporting.listing.infoPanel.callout.cloud.insufficientMemoryError"
-        defaultMessage="This report cannot be generated because Kibana does not have sufficient memory. See {helpUrl} for further information."
+        defaultMessage="This report cannot be generated. {link}."
         values={{
-          helpUrl: (
+          link: (
             <EuiLink href={helpUrl}>
               {i18n.translate(
                 'xpack.reporting.listing.infoPanel.callout.cloud.insufficientMemoryError.urlLink',
-                { defaultMessage: 'this documentation' }
+                { defaultMessage: 'See minimum RAM requirements' }
               )}
             </EuiLink>
           ),

diff --git a/x-pack/plugins/reporting/public/management/components/report_info_flyout_content.tsx b/x-pack/plugins/reporting/public/management/components/report_info_flyout_content.tsx
@@ -43,7 +43,7 @@ const createDateFormatter = (format: string, tz: string) => (date: string) => {
 
 export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info }) => {
   const {
-    services: { uiSettings },
+    services: { uiSettings, docLinks },
   } = useKibana();
 
   const timezone =
@@ -195,20 +195,23 @@ export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info }) => {
      * should only occur on cloud.
      */
     info.error_code === VisualReportingSoftDisabledError.code
-      ? i18nTexts.cloud.insufficientMemoryError('#')
+      ? i18nTexts.cloud.insufficientMemoryError(docLinks.links.reporting.cloudMinimumRequirements)
       : info.getError();
 
   return (
     <>
       {Boolean(errored) && (
-        <EuiCallOut
-          title={i18n.translate('xpack.reporting.listing.infoPanel.callout.failedReportTitle', {
-            defaultMessage: 'Report failed',
-          })}
-          color="danger"
-        >
-          {errored}
-        </EuiCallOut>
+        <>
+          <EuiCallOut
+            title={i18n.translate('xpack.reporting.listing.infoPanel.callout.failedReportTitle', {
+              defaultMessage: 'Report failed',
+            })}
+            color="danger"
+          >
+            {errored}
+          </EuiCallOut>
+          <EuiSpacer />
+        </>
       )}
       {Boolean(warnings) && (
         <>

diff --git a/x-pack/plugins/reporting/public/management/mount_management_section.tsx b/x-pack/plugins/reporting/public/management/mount_management_section.tsx
@@ -34,6 +34,7 @@ export async function mountManagementSection(
           http: coreSetup.http,
           application: coreStart.application,
           uiSettings: coreStart.uiSettings,
+          docLinks: coreStart.docLinks,
         }}
       >
         <InternalApiClientProvider apiClient={apiClient}>

diff --git a/x-pack/plugins/reporting/public/types.ts b/x-pack/plugins/reporting/public/types.ts
@@ -5,10 +5,11 @@
  * 2.0.
  */
 
-import type { HttpSetup, ApplicationStart, CoreSetup } from 'src/core/public';
+import type { CoreSetup, CoreStart } from 'src/core/public';
 
 export interface KibanaContext {
-  http: HttpSetup;
-  application: ApplicationStart;
-  uiSettings: CoreSetup['uiSettings'];
+  http: CoreSetup['http'];
+  application: CoreStart['application'];
+  uiSettings: CoreStart['uiSettings'];
+  docLinks: CoreStart['docLinks'];
 }