[Proposal] Migrate to fast-check #353
Conversation
| key: jsc.elements(['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h']), | ||
| value: jsc.nat, | ||
| }) as any | ||
| const arbitraryCommand = fc.record({ |
There was a problem hiding this comment.
There is a built-in way to deal with commands in fast-check. I could probably migrate the test to it.
| let numericType = fc | ||
| .double({ | ||
| next: true, | ||
| noDefaultInfinity: true, | ||
| noNaN: true, | ||
| min: -1 / numericTypeMinAccuracy, | ||
| max: 1 / numericTypeMinAccuracy, | ||
| }) | ||
| }) | ||
| .map(d => Math.round(d / numericTypeMinAccuracy) * numericTypeMinAccuracy) |
There was a problem hiding this comment.
Here the arbitrary fc.double was able to find potential issues when used with full resolution. Contrary to jsc.number it can generate any number from -Infinity to +Infinity including -0, Number.MIN_VALUE, Number.EPSILON and others (from small to large values).
| // If the above expect(...) assertion fails, we won't reach here. | ||
| return true |
There was a problem hiding this comment.
No need for return with fast-check. No return or return true is success. Throw or return false is failure.
|
Cc @jlfwong, jsverify is clearly dead today. Any blocker to switch to fast-check? More maintained, more powerful, more used... |
|
Hey @dubzzz! If you want to resolve the conflicts on this and get it through CI, I'm happy to merge a PR. I didn't take a careful look at this in the past because, despite jsverify being dead, that wasn't (and tbh, isn't) causing me any real pain, nor does this resolve any user facing issues. All that said, I agree it makes more sense to use a library that's maintained in an ongoing manner (especially if the creator is willing to do the migration for you 😄) |
What?
This Pull Request is mostly a proposal to migrate from jsverify to fast-check.
Why?
jsverify's owner stopped the maintenance of the library more than a year ago. In addition, the last real commit to jsverify was on the 6th of September 2019.
Benefits of
fast-checkoverjsverifymap(smapinjsverify).