Skip to content

Commit

Permalink
Correct formatting of C code (eclipse-cdt#843)
Browse files Browse the repository at this point in the history
Apply the coding standards to the C code from eclipse-cdt#840
  • Loading branch information
jonahgraham authored Jun 23, 2024
1 parent f39fa55 commit 24d9bd1
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
18 changes: 11 additions & 7 deletions core/org.eclipse.cdt.core.native/native_src/unix/exec_pty.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ extern char *pfind(const char *name, char *const envp[]);
static int sys_close_range_wrapper(unsigned int from_fd_inclusive) {
// Use fast `close_range` (https://man7.org/linux/man-pages/man2/close_range.2.html) if available.
// Cannot call `close_range` from libc, as it may be unavailable in older libc.
# if defined(__linux__) && defined(SYS_close_range) && defined(CLOSE_RANGE_UNSHARE)
#if defined(__linux__) && defined(SYS_close_range) && defined(CLOSE_RANGE_UNSHARE)
return syscall(SYS_close_range, from_fd_inclusive, ~0U, CLOSE_RANGE_UNSHARE);
# else
#else
errno = ENOSYS;
return -1;
# endif
#endif
}

static int close_all_fds_using_parsing(unsigned int from_fd_inclusive) {
Expand All @@ -57,7 +57,8 @@ static int close_all_fds_using_parsing(unsigned int from_fd_inclusive) {
#endif

DIR *dirp = opendir(FD_DIR);
if (dirp == NULL) return -1;
if (dirp == NULL)
return -1;

struct dirent *direntp;

Expand All @@ -77,16 +78,19 @@ static int close_all_fds_using_parsing(unsigned int from_fd_inclusive) {

static void close_all_fds_fallback(unsigned int from_fd_inclusive) {
int fdlimit = sysconf(_SC_OPEN_MAX);
if (fdlimit == -1) fdlimit = 65535; // arbitrary default, just in case
if (fdlimit == -1)
fdlimit = 65535; // arbitrary default, just in case
for (int fd = from_fd_inclusive; fd < fdlimit; fd++) {
close(fd);
}
}

static void close_all_fds() {
unsigned int from_fd = STDERR_FILENO + 1;
if (sys_close_range_wrapper(from_fd) == 0) return;
if (close_all_fds_using_parsing(from_fd) == 0) return;
if (sys_close_range_wrapper(from_fd) == 0)
return;
if (close_all_fds_using_parsing(from_fd) == 0)
return;
close_all_fds_fallback(from_fd);
}

Expand Down

0 comments on commit 24d9bd1

Please sign in to comment.