Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add extra version check for pull requests #67

Conversation

Jeruntu
Copy link
Collaborator

@Jeruntu Jeruntu commented Dec 15, 2024

  • This checks if the version specified in the config.yaml is available for every target.
    It is important to check this before the PR is merged tomaster, so the pipeline won't fail after the PR has been merged.
    • I tried to build and tag temporary images for PR's (to make sure everything is ok before the merge), but GitHub prohibits using secrets in a PR pipeline (Docker Hub credentials). It is hard to work around this and also discouraged.
    • The pipeline always builds the docker images for Dev without publishing. So as long as that works, and the versions for Beta and Stable are checked, everything should be ok for the merge.

@Jeruntu Jeruntu merged commit 6c480bb into jkunczik:master Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant