Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failed to parse sourcemaps error #593

Closed

Conversation

Taskle
Copy link

@Taskle Taskle commented Jul 28, 2023

This fixes the issue surfaced in #522 that generates console warnings for anyone who imports rrule into their project.

I've tested it locally in my forked version and it appears to remove the errors.

@davidgoli
Copy link
Collaborator

Thanks, for the contribution! The problem with this approach is it points to the src/ folder in the production output, which ideally we shouldn't be even publishing.

What I propose we do instead is not minify the published output, then you won't even need sourcemaps. Most end-stage build tools minify the whole bundle including node_modules in application code, so I don't think this will have too much downside.

@dargmuesli
Copy link

I've create two PRs which fix the situation for now:

@davidgoli I'd invite you to pick the one that makes more sense. Just having sourcemaps which point to non-existing source files makes not much, I'd say 🤙

@Taskle Taskle closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants