Fix bug with option key ordering. #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayoteramoto
approved these changes
Jun 27, 2022
|
@DarryQueen I've merged your other PR [#528] but now this one has conflicts. Please resolve them and I'll merge. |
|
Done, merge conflicts resolved. |
DarryQueen
commented
Nov 11, 2023
| import { optionsToString } from '../src/optionstostring' | ||
| import { DateFormatter } from '../src/nlp/totext' | ||
| import { datetime } from './lib/utils' | ||
|
|
||
| const texts = [ | ||
| ['Every day', 'RRULE:FREQ=DAILY'], | ||
| ['Every day at 10, 12 and 17', 'RRULE:FREQ=DAILY;BYHOUR=10,12,17'], | ||
| [ | ||
| 'Every week on Sunday at 10, 12 and 17', |
There was a problem hiding this comment.
I removed this and moved it down in with "~ approximate" because it is technically not fully supported; byhour is not fully convertible for weekly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for
isFullyConvertibleis sensitive to the key ordering oforigOptionsbecause it short-circuits once it sees one of the ignored keys. I imagine this is a bug; the ignored keys should just be skipped over in the loop.