feat(nlp): support weekly by hour texts (#590)

* feat(nlp): support weekly by hour texts e.g. 'every week on Sunday at 10, 12 and 17' would serialize to 'RRULE:FREQ=WEEKLY;BYDAY=SU;BYHOUR=10,12,17' * after prettier * forgot to add a case
jkbrzt · Nov 10, 2023 · 62e7320 · 62e7320
1 parent 8713aa5
commit 62e7320
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/nlp/parsetext.ts b/src/nlp/parsetext.ts
@@ -126,13 +126,15 @@ export default function parseText(text: string, language: Language = ENGLISH) {
  options.freq = RRule.WEEKLY
  options.byweekday = [RRule.MO, RRule.TU, RRule.WE, RRule.TH, RRule.FR]
  ttr.nextSymbol()
+ AT()
  F()
  break
 
  case 'week(s)':
  options.freq = RRule.WEEKLY
  if (ttr.nextSymbol()) {
  ON()
+ AT()
  F()
  }
  break
@@ -198,6 +200,7 @@ export default function parseText(text: string, language: Language = ENGLISH) {
  options.byweekday.push(RRule[wkd] as ByWeekday)
  ttr.nextSymbol()
  }
+ AT()
  MDAYs()
  F()
  break

diff --git a/src/nlp/totext.ts b/src/nlp/totext.ts
@@ -281,6 +281,10 @@ export default class ToText {
  } else if (this.byweekday) {
  this._byweekday()
  }
+
+ if (this.origOptions.byhour) {
+ this._byhour()
+ }
  }
  }
 

diff --git a/test/nlp.test.ts b/test/nlp.test.ts
@@ -7,6 +7,10 @@ import { datetime } from './lib/utils'
 const texts = [
  ['Every day', 'RRULE:FREQ=DAILY'],
  ['Every day at 10, 12 and 17', 'RRULE:FREQ=DAILY;BYHOUR=10,12,17'],
+ [
+ 'Every week on Sunday at 10, 12 and 17',
+ 'RRULE:FREQ=WEEKLY;BYDAY=SU;BYHOUR=10,12,17',
+ ],
  ['Every week', 'RRULE:FREQ=WEEKLY'],
  ['Every hour', 'RRULE:FREQ=HOURLY'],
  ['Every 4 hours', 'RRULE:INTERVAL=4;FREQ=HOURLY'],