Retrieve maxshape for Dataset #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
reviewed
Feb 22, 2024
pyfive/dataobjects.py
Outdated
| @@ -648,6 +657,8 @@ def is_dataset(self): | |||
| """ True when DataObjects points to a dataset, False for a group. """ | |||
| return len(self.find_msg_type(DATASPACE_MSG_TYPE)) > 0 | |||
|
|
|||
| UNLIMITED_SIZE = struct.unpack('<Q', b'\xff\xff\xff\xff\xff\xff\xff\xff')[0] | |||
There was a problem hiding this comment.
Fair enough :) this was copy-paste from some earlier code, which has since been refactored to be
UNDEFINED_ADDRESS = 0xffffffffffffffff(https://github.com/jjhelmus/pyfive/blob/master/pyfive/core.py#L10), which could also be re-used here as a constant.
|
The use of |
…om existing UNDEFINED_ADDRESS, as they have the same value
|
LGTM, thanks for the PR |
jjhelmus
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieving maxshape from dataobjects and exposing maxshape property on Dataset
closes #50