Bug fixes and encoding changes. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
另外，部分代码文件使用了gb2312编码，在unix系统下为乱码，我将其转换成了utf-8编码 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以第5步为例 else if 的条件}else if(pp.type.equals("python")){错误，此处应该为}else if(icgen.type.equals("python")){，其他步类似，都错误的写成了}else if(pp.type.equals("python")){
另外，建议将icgen.path != ""修改为!Objects.equals(optimizing.path)，因为== 以及!=符号对于字符串来说，是进行引用的比较而非值的比较，进行值的比较应该使用equals方法