feat(rtcstats): move conference start time to ljm #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Jul 8, 2024
| // statisticsId -> email, this is only send by jitsi-meet if enableEmailInStats option is set. | ||
| // statisticsDisplayName -> nick, this is only send by jitsi-meet if enableDisplayNameInStats option is set. | ||
| // localId, this is the unique id that is used to track users throughout stats. | ||
| const localId = Settings?.callStatsUserName ?? ''; |
There was a problem hiding this comment.
If no unique name is provided, shouldn't we generate sonething random, instead of using the empty string and potentially mixing things up?
There was a problem hiding this comment.
I don't know if this would be the place to do that, the callStatsUserName is saved locally and the most common use case for it is to track session originating from the same medium (browser, app, etc).
If we were to generate something unique it won't do us much good as we already have a statsSessionId which is unique per session. Having it empty would at least signal that callStatsUserName isn't properly set in some envs.
|
Jenkins please test this please. |
1 similar comment
|
Jenkins please test this please. |
andrei-gavrilescu
force-pushed
the
feat/move-rtcstats-events-to-ljm
branch
from
4003891
to
6437767
Compare
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.