Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Settings) use a proper UUID rather than hand-rolling it #2039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Settings) use a proper UUID rather than hand-rolling it #2039

wants to merge 1 commit into from
+4 −17

Conversation

saghul
Copy link
Member

@saghul saghul commented Jun 21, 2022

Note the format changes, is that important?

@NewEraCracker
Copy link
Contributor

If you replace all dashes with nothing: .replace(/-/g,'') then the ID would be 32 chars length. Same length as the ancient format and likely without any backward issues as both are using hexadecimal alphabet.

@saghul
Copy link
Member Author

saghul commented Jun 23, 2022

Excellent point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @NewEraCracker