Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ScreenObtainer): add support for tab capture on Electron #1874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielMcAssey
Copy link
Contributor

With electron/electron#31204 being merged into Electron and released with Electron 17.x.x, Electron can now capture individual WebContents (Tabs). This change allows the standard flow to support tab capture

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@sapkra sapkra added the feature-request Issue is really a feature request label Feb 6, 2022
@saghul
Copy link
Member

saghul commented Feb 6, 2022

But how to "tabs" manifest on Electron? Like Chrome tabs?

@DanielMcAssey
Copy link
Contributor Author

DanielMcAssey commented Feb 6, 2022

Essentially yeah, so you can have a BrowserWindow with different WebContents (Tabs), in addition capturing the WebContents also removes the Window Frame

@saghul
Copy link
Member

saghul commented Feb 7, 2022

I see. We need to make sure this does not break existing apps before landing it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issue is really a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants