feat(ScreenObtainer): add support for tab capture on Electron #1874
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
But how to "tabs" manifest on Electron? Like Chrome tabs? |
|
Essentially yeah, so you can have a BrowserWindow with different WebContents (Tabs), in addition capturing the WebContents also removes the Window Frame |
|
I see. We need to make sure this does not break existing apps before landing it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With electron/electron#31204 being merged into Electron and released with Electron 17.x.x, Electron can now capture individual WebContents (Tabs). This change allows the standard flow to support tab capture