Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: keyboard navigation on the toolbar #15054

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Aug 26, 2024

Description: when user use the keyboard navigation and have the focus on the toolbar. this focus should stay till the user tab out of the toolbar.

Actual Behavior: Toolbar menu disappear after a certain time even with the focus on it.

Expected Behavior: Toolbar should stay visible on focus (and closed on blur) and on mouse hover (and closed on mouse out).

before:

beforeFixToolbarKeyboardocus.mp4

after:

afterFixToolbarKeyboeadFocus.mp4

issue jitsi community: https://community.jitsi.org/t/accessibility-keyboard-navigation/133334

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Sep 2, 2024

@Calinteodor can you PTAL?

@ahmadkadri
Copy link
Contributor Author

@saghul is there any update on this PR?

@Calinteodor
Copy link
Contributor

Jenkins test this please.

@Calinteodor
Copy link
Contributor

@saghul is there any update on this PR?

@ahmadkadri It seems there is a failing test on Firefox. Please check it. Thank you.

@emrahcom
Copy link
Contributor

Please, could you run the test again.
I think this PR is OK after jitsi/jitsi-meet-torture#653

@damencho
Copy link
Member

Jenkins test this please.

@Calinteodor
Copy link
Contributor

@ahmadkadri @emrahcom There is still one test failing. Can you check it please?

@emrahcom
Copy link
Contributor

Hi @Calinteodor,
I think this PR fixes it.

@damencho
Copy link
Member

Jenkins test this please.

@damencho damencho merged commit 176e409 into jitsi:master Oct 9, 2024
10 checks passed
@damencho
Copy link
Member

damencho commented Oct 9, 2024

Thank you for your contribution.

aashot pushed a commit to aashot/jitsi-meet that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants