feat(livestream): add separate fields for stream URL and stream key #13306
Conversation
|
Hi, thanks for your contribution! |
react/features/recording/components/LiveStream/AbstractStartLiveStreamDialog.ts
Show resolved
Hide resolved
| if (!key) { | ||
| return false; | ||
| } | ||
|
|
||
| const rtmpURL = base.endsWith('/') ? base + key : `${base}/${key}`; |
There was a problem hiding this comment.
We should ensure we preserve the functionality of providing a full RTMP URL instead of base + key, for services which may not have the key as the final part of the path.
There was a problem hiding this comment.
Sure, good point. I made the key field optional, so you can input the full RTMP URL in the first field if needed.
roanta2
force-pushed
the
roanta/livestream-add-field
branch
from
a4f2852
to
38ab95a
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Add separate fields for Stream URL( will appear pre-typed with default yt rtmp) and Stream key, similar to how it is presented in the youtube dashboard. This also makes it more obvious that you can use other stream URLs rather than the youtube one. Should be merged before this PR on jibri: jitsi/jibri#508 that supports these changes.