Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove browser checks that are no longer applicable. #605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove browser checks that are no longer applicable. #605

wants to merge 2 commits into from

Conversation

jallamsetty1
Copy link
Member

No description provided.

damencho
damencho reviewed Jun 20, 2023
View reviewed changes
src/test/java/org/jitsi/meet/test/MuteTest.java Outdated
@@ -249,7 +249,7 @@ private void muteParticipant1BeforeParticipant2JoinsAndScreenshare(String enable
WebParticipant participant1 = getParticipant1();

// Skip the test in p2p mode for Firefox since p2p is disabled in code for Firefox.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's remove and the comment :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought I removed the comment as well.

@damencho
Copy link
Member

This test failure is strange ...

@damencho
Copy link
Member 

2023-06-20T17:11:45.218Z [modules/RTC/JitsiRemoteTrack.js] <Zd._onTrackMute>:  "onmute" event(1687281105218): RemoteTrack[userID: b8b82dad, type: video, ssrc: 3316945610, p2p: false, sourceName: b8b82dad-v0, status: {readyState: live, muted: true, enabled: true}]
2023-06-20T17:11:45.218Z [modules/connectivity/TrackStreamingStatus.ts] <qd.onTrackRtcMuted>:  Detector track RTC muted: b8b82dad-v0 1687281105218
2023-06-20T17:11:48.265Z [modules/statistics/AudioOutputProblemDetector.js] A potential problem is detected with the audio output for participant b8b82dad, local audio levels: [null,null], remote audio levels: undefined
2023-06-20T17:11:55.218Z [modules/connectivity/TrackStreamingStatus.ts] Set track RTC muted for: b8b82dad-v0 after the timeout of 10000 ms
2023-06-20T17:11:55.219Z [modules/connectivity/TrackStreamingStatus.ts] <qd.figureOutStreamingStatus>:  Figure out conn status for b8b82dad-v0, is video muted: false video track frozen: true p2p mode: false is in forwarded sources: true currentStatus => newStatus: active => restoring

@jallamsetty1
Copy link
Member Author

Jenkins please test this

@damencho
Copy link
Member

Jenkins test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damencho damencho damencho left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jallamsetty1 @damencho