Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): improve modal and add hang up confirmation #1080

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

andrei-gavrilescu
Copy link
Contributor

Add some enhancements to modal (make it can't be clicked through)
Screenshot 2024-08-05 at 11 22 47
Add hang up confirmation.
Screenshot 2024-08-05 at 11 53 53

saghul
saghul previously approved these changes Aug 6, 2024
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Pl try to run the e2e tests locally, I bet some of them need to be adjusted for the hangup change.

There are some that fail in the CI, which we can keep ignoring for a while longer.

@andrei-gavrilescu
Copy link
Contributor Author

Excellent work! Pl try to run the e2e tests locally, I bet some of them need to be adjusted for the hangup change.

There are some that fail in the CI, which we can keep ignoring for a while longer.

Seems like these fail randomly, it might have something to do with the duplicate events problem, I'll check to see if adding a fix there makes them more consistent.

@andrei-gavrilescu andrei-gavrilescu merged commit 0857837 into master Aug 14, 2024
4 of 5 checks passed
@andrei-gavrilescu andrei-gavrilescu deleted the feat/add-hang-up-confirmation branch August 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants