feat(setup) select preferred resolution #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihhu
force-pushed
the
preferred-resolution
branch
from
0ead689
to
acc383d
Compare
saghul
reviewed
Sep 5, 2023
spot-client/src/spot-tv/ui/components/setup/select-media/select-media.js
Outdated
Show resolved
Hide resolved
| * @param {string} preferredResolution - The resolution of choice. | ||
| * @returns {boolean} | ||
| */ | ||
| export const getVideoConstraints = (preferredAspectRatio, preferredResolution) => { |
There was a problem hiding this comment.
Where does the aspect ratio come from? I think we should use 16 / 9 at all times. Regardless of the size of the app window, cameras support stabndard aspect ratios, and requiring 16 / 9 for an in-room device sounds very reasonable.
There was a problem hiding this comment.
I used this, but I'll switch it to 16 / 9.
mihhu
force-pushed
the
preferred-resolution
branch
from
acc383d
to
c2be831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.