feat(logger) send logs to aws #1030
Open
+2,735
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Sep 5, 2023
| @@ -28,6 +29,12 @@ require('./src/client-control'); | |||
| require('./src/exit'); | |||
| require('./src/volume-control'); | |||
|
|
|||
| process.env.USE_CLOUDWATCH_LOGS && awsLogger.maybeCreateLogStream() | |||
There was a problem hiding this comment.
How is the Electron app going to get these env variables?
There was a problem hiding this comment.
I was thinking that the person that installs the app can set up these too.
There was a problem hiding this comment.
That won't work since the app is deployed fully packaged and the environment cannot be set just for that app, you'd need to launch it from the terminal or something.
I think the right thing to do is to use a JSON file which we can add in branding, and the code can read it from there.
There was a problem hiding this comment.
How about the AWS credentials?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.