fix(gha) make sure the chosen Node version is used

jitsi · Sep 5, 2024 · 04424d3 · 04424d3
1 parent e431e11
commit 04424d3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/.github/workflows/ci_spot-client.yml b/.github/workflows/ci_spot-client.yml
@@ -12,9 +12,7 @@ jobs:
             - name: Step 2 - setup node
               uses: actions/setup-node@v4
               with:
-                  node-version: 20
-                  cache: 'npm'
-                  cache-dependency-path: spot-client/package-lock.json
+                node-version-file: '.nvmrc'
 
             - name: Step 3 - run install
               working-directory: 'spot-client'
@@ -39,19 +37,24 @@ jobs:
             - name: Step 2 - checkout
               uses: actions/checkout@v4
 
-            - name: Step 3 - run install [spot-client]
+            - name: Step 3 - setup node
+              uses: actions/setup-node@v4
+              with:
+                node-version-file: '.nvmrc'
+
+            - name: Step 4 - run install [spot-client]
               working-directory: spot-client
               run: npm install
 
-            - name: Step 4 - run install [spot-webdriver]
+            - name: Step 5 - run install [spot-webdriver]
               working-directory: spot-webdriver
               run: npm install
 
-            - name: Step 5 - run tests [spot-webdriver]
+            - name: Step 6 - run tests [spot-webdriver]
               working-directory: spot-webdriver
               run: npm run ci
 
-            - name: Step 6 - Archive Test Results
+            - name: Step 7 - Archive Test Results
               if: always()
               uses: actions/upload-artifact@v4
               with:

diff --git a/.github/workflows/ci_spot-electron.yml b/.github/workflows/ci_spot-electron.yml
@@ -12,9 +12,7 @@ jobs:
             - name: Step 2 - setup node
               uses: actions/setup-node@v4
               with:
-                  node-version: 20
-                  cache: 'npm'
-                  cache-dependency-path: spot-electron/package-lock.json
+                node-version-file: '.nvmrc'
 
             - name: Step 3 - run install
               working-directory: 'spot-electron'
@@ -35,9 +33,7 @@ jobs:
             - name: Step 2 - setup node
               uses: actions/setup-node@v4
               with:
-                  node-version: 20
-                  cache: 'npm'
-                  cache-dependency-path: spot-electron/package-lock.json
+                node-version-file: '.nvmrc'
 
             - name: Step 3 - run install
               working-directory: 'spot-electron'
@@ -58,9 +54,7 @@ jobs:
             - name: Step 2 - setup node
               uses: actions/setup-node@v4
               with:
-                  node-version: 20
-                  cache: 'npm'
-                  cache-dependency-path: spot-electron/package-lock.json
+                node-version-file: '.nvmrc'
 
             - name: Step 3 - run install
               working-directory: 'spot-electron'