Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unused references in instance launcher #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: remove unused references in instance launcher #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,6 @@ const instanceLauncher = new InstanceLauncher({
instanceTracker,
cloudManager,
instanceGroupManager,
lockManager,
redisClient,
shutdownManager,
audit,
metricsLoop,
Expand Down
8 changes: 0 additions & 8 deletions src/instance_launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { InstanceDetails, InstanceState, JibriStatusState, InstanceTracker } from './instance_tracker';
import CloudManager from './cloud_manager';
import InstanceGroupManager, { InstanceGroup } from './instance_group';
import Redis from 'ioredis';
import LockManager from './lock_manager';
import { Context } from './context';
import * as promClient from 'prom-client';
import ShutdownManager from './shutdown_manager';
Expand Down Expand Up @@ -32,8 +30,6 @@ export interface InstanceLauncherOptions {
instanceTracker: InstanceTracker;
cloudManager: CloudManager;
instanceGroupManager: InstanceGroupManager;
lockManager: LockManager;
redisClient: Redis.Redis;
shutdownManager: ShutdownManager;
audit: Audit;
metricsLoop: MetricsLoop;
Expand All @@ -44,8 +40,6 @@ export default class InstanceLauncher {
private instanceTracker: InstanceTracker;
private instanceGroupManager: InstanceGroupManager;
private cloudManager: CloudManager;
private redisClient: Redis.Redis;
private lockManager: LockManager;
private shutdownManager: ShutdownManager;
private audit: Audit;
private metricsLoop: MetricsLoop;
Expand All @@ -54,8 +48,6 @@ export default class InstanceLauncher {
this.instanceTracker = options.instanceTracker;
this.cloudManager = options.cloudManager;
this.instanceGroupManager = options.instanceGroupManager;
this.lockManager = options.lockManager;
this.redisClient = options.redisClient;
this.shutdownManager = options.shutdownManager;
this.audit = options.audit;
this.metricsLoop = options.metricsLoop;
Expand Down