Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content-Type to Shibboleth handler response #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxbes
Copy link

@maxbes maxbes commented Oct 29, 2020

Currently, the Shibboleth handler (/login) does not set a Content-Type:

image

This can cause issues with certain reverse proxies, certain default Content-Type configurations, or when using X-Content-Type-Options: nosniff . In those cases the HTML source code can appear in the browser window instead of being rendered

This PR adds the missing Content-Type header

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@maxbes
Copy link
Author

maxbes commented Oct 29, 2020

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants