Create a socket pool of multiple sockets bound to the same port #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reads without blocking.
For testing outside the maven contex.
Let the sockets themselves do the blocking, no need for extra synchronization.
JonathanLennox
force-pushed
the
socketpool
branch
from
1dde751
to
6182860
Compare
(And thus SinglePortUdpHarvester.)
JonathanLennox
changed the title
bgrozev
reviewed
Oct 22, 2024
| requestedNumSockets | ||
| } else { | ||
| // TODO: set this to 1 in situations where pools aren't needed? | ||
| 2 * Runtime.getRuntime().availableProcessors() |
There was a problem hiding this comment.
I suggest logging the number we end up using.
Why does it default to twice the number of processors? Running your test on an A2 with 8 CPUs I see optimal performance for 8 sockets.
There was a problem hiding this comment.
I was testing on a 4-core machine, but if JVB is using an 8 core one your tests are probably more representative. (My tests were also pretty noisy; I suspect the host my lonely instance is on is pretty busy.)
bgrozev
previously approved these changes
Oct 22, 2024
bgrozev
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can send from the same local IP and port from multiple threads simultaneously on Java 18+.