Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(NetworkUtils): Remove unused utils. #279

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented May 23, 2024

These utilities are no longer used by jitsi desktop or any other jitsi project I could find, so imo they are not worth maintaining in ice4j:

boolean isValidIPAddress(String address)
boolean isIPv4Address(String address)
boolean isIPv6Address(String address)
byte[] strToIPv4(String ipv4AddrStr)
byte[] strToIPv6(String ipv6AddrStr)
byte[] mappedIPv4ToRealIPv4(byte[] addr)

There are readily available alternatives in e.g. Guava's InetAddresses:

boolean isInetAddress(String ipString)
byte[] ipStringToBytes(String ipStringParam)
Inet4Address getEmbeddedIPv4ClientAddress(Inet6Address ip)

@bgrozev bgrozev requested a review from ibauersachs May 23, 2024 15:01
@bgrozev bgrozev merged commit b2c8f4d into jitsi:master Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants