Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Drive image compilation with JITSI_IMAGE_VERSION #1853

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Berbe
Copy link
Contributor

@Berbe Berbe commented Jul 3, 2024

The JITSI_IMAGE_VERSION environment variable, part of env.example, is already made for driving images tag selection at runtime.

This proposal aims at:

  • Using JITSI_IMAGE_VERSION environment variable also at build time, making image generation and stack deployment coherent
  • Ensuring compilation of all images is done with that same tag

@saghul
Copy link
Member

saghul commented Aug 5, 2024

This would break the current workflow of make prepare creating latest images for testing.

@saghul
Copy link
Member

saghul commented Aug 5, 2024

The release.sh script would be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants