Display image inside of indicator #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mako does something similar.
Initializing to 1 is incorrect when the surface scale is > 1.
We incorrectly used the buffer size instead of the surface size. Let's not bother and just damage the maximum region.
Signed-off-by: Elyes HAOUAS <[email protected]>
An odd value of fe.height lead to the indicator disappearing. This was due to the buffer size no longer being a multiple of the buffer scale. This commit fixes the issue by checking both height and width to be a multiple of scale. This is done early to avoid excessive re-calls of create_buffer if the buffer_height != new_height in render.c line 314 (now 318).
sync with swaywm/swaylock
|
Please resolve the file conflict. |
Yeah. Haven't really had that much time. Will during the weekend :) |
|
Can't really test the changes due to #3 |
Update README.md to reflect Fedora COPR maintenance change
|
@jirutka It's ready now :) |
MichaelPachec0
added a commit
to MichaelPachec0/nix-config
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Michael Pacheco <[email protected]>
jirutka
reviewed
Aug 12, 2023
jirutka
reviewed
Aug 12, 2023
jirutka
reviewed
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From mortie#89
Fixes #68
Requires #20
Description:
Displays an image inside of the indicator behind the inside of the indicator (the clock, text, and its background)
Example:
swaylock --indicator-image /PATH/TO/SOME/IMAGEor: