Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow singleton dimensions in PencilArray #55

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow singleton dimensions in PencilArray #55

wants to merge 7 commits into from

Conversation

jipolanco
Copy link
Owner

No description provided.

@jipolanco
Copy link
Owner Author

Thinking about it, I'm not sure singleton dimensions are the best solution for broadcasting along dimensions that should behave like "constants".

The problem is that a (locally) singleton dimension doesn't always imply a "constant" dimension. For instance, if a given dimension has global size N and it is distributed along N processes, then the local size is 1, but this is not a "constant" dimension.

A better alternative would be to provide a Constant flag for dimensions that should behave like it, analogous to e.g. Flat in Oceananigans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jipolanco