Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port-forward: Completion for exposed ports on services #245

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

jinnovation
Copy link
Owner

Contributes to #240.

kele.el Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.65%. Comparing base (e9d5e8f) to head (e226b06).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kele.el 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   55.58%   55.65%   +0.07%     
==========================================
  Files           1        1              
  Lines         869      884      +15     
==========================================
+ Hits          483      492       +9     
- Misses        386      392       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinnovation jinnovation changed the title Implement function to get the ports from a service Port-forward: Completion for exposed ports on services Sep 23, 2024
@jinnovation jinnovation marked this pull request as ready for review September 27, 2024 21:29
@jinnovation jinnovation merged commit 09c465a into main Sep 27, 2024
5 checks passed
@jinnovation jinnovation deleted the get-service-ports branch September 27, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants