Fix EdgeTts xml escaping #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values-en/strings.xml
New Crowdin updates
New Crowdin updates
This reverts commit 7b589f4.
jing332
force-pushed
the
compose
branch
3 times, most recently
from
07217a8
to
875dff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am hearing the TTS saying &apos when it tries to read a '
I took a look at https://github.com/rany2/edge-tts/blob/master/src/edge_tts/communicate.py#L375 and I see that it's using https://github.com/python/cpython/blob/3.12/Lib/xml/sax/saxutils.py#L27 which only escapes &<>
I changed it to only escape those and it seems to work fine now.