Support custom Procfile #27 #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling detect Procfile in build directory and then read from Procfile trying to publish all dlls found in Procfile. Extract publish to function.
Closed
jincod
reviewed
Jan 1, 2018
|
|
||
| if [ -e "$BUILD_DIR/Procfile" ]; then | ||
| numberOfProjects=0 | ||
| while read line || [[ -n "$line" ]]; |
There was a problem hiding this comment.
It does mean support of multiple projects? I think we can't do it, because only one web process instruction per file available
There was a problem hiding this comment.
Apologies for the delay in reply, I was away.
The code iterates the entries in the Procfile, try to match a valid dll and then publish.
Use the count of valid projects to determine exit code.
While there can only be one web process type there can be multiple other arbitrarily named processes (worker processes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation for #27
When compiling and Procfile found:
cd $HOME/heroku_outputin Procfile