Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install through installer script #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Install through installer script #16

wants to merge 3 commits into from
+35 −18

Conversation

francipvb
Copy link

  • Added script installation process
  • Added the SDK download to the cache
  • Added a function to detect if a .csproj file is a valid web project
    • It uses python3 (installed by default into heroku)
    • Currently this function isn't used
  • Added a .gitattributes to solve testing problems under Docker for Windows

This is to solve #14.

@francipvb
Changes:
4336cbe 
  * Added script installation process
  * Added the SDK download to the cache
  * Added a function to detect if a .csproj file is a valid web project
    - It uses python3 (installed by default into heroku)
    - Currently this function isn't used
francipvb
francipvb commented Aug 27, 2017
View reviewed changes
bin/compile
@@ -7,11 +7,6 @@ set -o pipefail # don't ignore exit codes when piping output
set -o nounset # fail on unset variables
unset GIT_DIR # Avoid GIT_DIR leak from previous build steps

if [ "$STACK" != "heroku-16" ]; then
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove this because with the script installer it is not needed.

@francipvb
Copy link
Author

Hello @jincod

Here is a solve path of this.

Please test it, I've tested it and it works fine.

Cheers,

@francipvb
Copy link
Author

Hello,

Note that by default the installer script searches in the current directory for a globa..json to determine the SDK version that needs to be installed.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francipvb @jincod