Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuse session #6196

Merged
merged 4 commits into from
Sep 15, 2024
Merged

fix: reuse session #6196

merged 4 commits into from
Sep 15, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 13, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Sep 13, 2024
@github-actions github-actions bot added size/M area/cli This issue/PR affects the command line interface area/testing This issue/PR affects testing component/client labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.

Project coverage is 19.04%. Comparing base (3e0943f) to head (8136939).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
jina/clients/base/http.py 0.00% 33 Missing ⚠️
jina/clients/base/helper.py 0.00% 9 Missing ⚠️
jina/clients/http.py 0.00% 5 Missing ⚠️
jina/clients/base/__init__.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3e0943f) and HEAD (8136939). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3e0943f) HEAD (8136939)
jina 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6196       +/-   ##
===========================================
- Coverage   47.13%   19.04%   -28.09%     
===========================================
  Files         150      150               
  Lines       14147    14191       +44     
===========================================
- Hits         6668     2703     -3965     
- Misses       7479    11488     +4009     
Flag Coverage Δ
jina 19.04% <3.92%> (-28.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the feat-reuse-session branch 5 times, most recently from 58a6728 to 8136939 Compare September 15, 2024 14:50
@JoanFM JoanFM changed the title feat: reuse session fix: reuse session Sep 15, 2024
@JoanFM JoanFM marked this pull request as ready for review September 15, 2024 15:59
@JoanFM JoanFM merged commit fbdde03 into master Sep 15, 2024
129 checks passed
@JoanFM JoanFM deleted the feat-reuse-session branch September 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/M size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants