Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix optim issue with optimization #6184

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: fix optim issue with optimization #6184

merged 1 commit into from
Jul 23, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 23, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.07%. Comparing base (e3ea29f) to head (0d5f644).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6184      +/-   ##
==========================================
+ Coverage   54.92%   57.07%   +2.14%     
==========================================
  Files         150      150              
  Lines       14125    14142      +17     
==========================================
+ Hits         7758     8071     +313     
+ Misses       6367     6071     -296     
Flag Coverage Δ
jina 57.07% <100.00%> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the fix-optim-dbatch branch from 0d5f644 to fd361f5 Compare July 23, 2024 14:05
@JoanFM JoanFM merged commit 6e29377 into master Jul 23, 2024
126 of 128 checks passed
@JoanFM JoanFM deleted the fix-optim-dbatch branch July 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant