Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codecov): exclude lines #2101

Merged
merged 3 commits into from
Mar 2, 2021
Merged

ci(codecov): exclude lines #2101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69fa96b
ci(codecov): exclude lines
Yongxuanzhang Mar 1, 2021
0302138
ci(codecov): move file
Yongxuanzhang Mar 1, 2021
25de2ec
ci(codecov): move file
Yongxuanzhang Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# .coveragerc to control coverage.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to affect the coverage locally or the coverage in codecov. If it is locally, u should try to create 2 reports with and without this file and see if there is difference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be " coverage in codecov".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this may not be the correct way to configure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related issue: codecov/codecov-python#107

[report]
# regrexes for lines to exclude from consideration
exclude_lines =
NotImplementedError