Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

feat: add score document support in csv #696

Merged
merged 17 commits into from
Mar 21, 2023
Merged

feat: add score document support in csv #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e127ba2
feat: add score document support in csv
bwanglzu Mar 19, 2023
05c5053
refactor: add csv handlers
bwanglzu Mar 19, 2023
6477723
refactor: remove build finetuning dataset
bwanglzu Mar 19, 2023
358e78a
test: add unit tests
bwanglzu Mar 19, 2023
1101463
test: fix csv reader add stringio as hints
bwanglzu Mar 19, 2023
5d6636c
feat: rename modality variable to col1 col2
bwanglzu Mar 19, 2023
1595093
test: add unit test
bwanglzu Mar 19, 2023
01762f9
feat: use a trial input size for mlp
bwanglzu Mar 20, 2023
6787dc0
feat: use a trial input size for mlp
bwanglzu Mar 20, 2023
c13d25d
refactor: fix task when model is mlp
bwanglzu Mar 20, 2023
5be341f
chore: add changelog
bwanglzu Mar 20, 2023
b2beaa7
feat: improve variable names and docstring
bwanglzu Mar 20, 2023
8e176ec
feat: rename handler to parser
bwanglzu Mar 20, 2023
8045671
feat: add docstring to csv context
bwanglzu Mar 20, 2023
2b3d330
test: debug experiment endpoint
bwanglzu Mar 20, 2023
c2a110f
test: debug experiment endpoint
bwanglzu Mar 20, 2023
b40611e
chore: update changelog
bwanglzu Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Support pair-wise score document construction from CSV. ([#696](https://github.com/jina-ai/finetuner/pull/696))

### Removed

### Changed

- Refactor `load_finetuning_dataset` into CSV handlers. ([#696](https://github.com/jina-ai/finetuner/pull/696))

### Fixed

### Docs
Expand Down
2 changes: 1 addition & 1 deletion finetuner/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def list_experiments(self, page: int = 1, size: int = 50) -> Dict[str, Any]:
..note:: The maximum number for `size` per page is 100.
"""
params = {'page': page, 'size': size}
url = self._construct_url(self._base_url, API_VERSION, EXPERIMENTS)
url = self._construct_url(self._base_url, API_VERSION, EXPERIMENTS) + '/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be don in the construct_url function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later we will investigate why this is happening

return self._handle_request(url=url, method=GET, params=params)

def delete_experiment(self, name: str) -> Dict[str, Any]:
Expand Down
1 change: 1 addition & 0 deletions finetuner/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
ARTIFACT = 'artifact'
ARTIFACT_ID = 'artifact_id'
DEFAULT_TAG_KEY = 'finetuner_label'
DEFAULT_TAG_SCORE_KEY = 'finetuner_score'
# Run status
CREATED = 'CREATED'
STARTED = 'STARTED'
Expand Down
Loading