MB-54729: Enable history scan for CDC backfill

Replace the todo markers with code that now utilises the magma history API - this now means scanAllVersions for example is hooked into the magma history scanning API. Add new tests that validate multiple versions can be stored and returned. Also required are changes to unit tests to respect new expectation checks that occur in magma - primarily that flushing writes ordered batches - this is only a problem for tests which bypass the flusher and call KVStore directly. **** ISSUES **** ep-engine_ep_unit_tests does not pass: 1) Exception from magma MagmaKVStoreRollbackTest.Rollback hits the following exception GSL: Precondition failure: 'levelSize >= compactionState[level].history.Size' at /Users/jimwalker/Code/couchbase/neo/magma/lsm/lsm_tree.cc:895 2) Seg-fault in magma Seen in a number of tests, 1 example: CollectionsDcpEphemeralOrPersistent/CollectionsDcpParameterizedTest.DefaultCollectionDropped/persistent_magma_value_only Process 78731 stopped * thread couchbase#1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT) frame #0: 0x00000001012eb7b0 ep-engine_ep_unit_tests`magma::DocSequenceBuffer::GetKey(this=0x0000000118131700) at lsd.cc:75:36 [opt] 72 } 73 74 Slice DocSequenceBuffer::GetKey() { -> 75 seqFmt.Set(sortedList[offset]->seqno); 76 return seqFmt.Encode(); 77 } 78 * thread couchbase#1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT) * frame #0: 0x00000001012eb7b0 ep-engine_ep_unit_tests`magma::DocSequenceBuffer::GetKey(this=0x0000000118131700) at lsd.cc:75:36 [opt] frame couchbase#1: 0x0000000101361e2e ep-engine_ep_unit_tests`magma::mvccIteratorAdaptor::GetKey(this=0x0000000118536c00) at mvcc.h:249:25 [opt] frame couchbase#2: 0x000000010132b688 ep-engine_ep_unit_tests`magma::IteratorWithFilter::filterKeys(this=0x0000000118128350) at iterator.cc:214:32 [opt] frame couchbase#3: 0x000000010132de5b ep-engine_ep_unit_tests`magma::KVReader::ReadKVs(this=0x00007ff7bfefd550) at common.cc:70:19 [opt] frame couchbase#4: 0x0000000101378f63 ep-engine_ep_unit_tests`magma::LSMTree::writeSSTable(this=0x000000011855a820, w=0x00007ff7bfefd890, itr=0x0000000118128350, maxSn=10, stopFn=function<bool (const magma::Slice &)> @ 0x00007ff7bfefd860)>) at lsm_tree.cc:719:15 [opt] frame couchbase#5: 0x0000000101376ee8 ep-engine_ep_unit_tests`magma::LSMTree::writeSSTable(this=0x000000011855a820, appendMode=<unavailable>, itr=0x0000000118128350, sizeEstimate=<unavailable>, maxSn=10, stopFn=function<bool (const magma::Slice &)> @ 0x00007ff7bfefdb60)>) at lsm_tree.cc:682:17 [opt] frame couchbase#6: 0x00000001013761b2 ep-engine_ep_unit_tests`magma::LSMTree::writeMemtable(this=0x000000011855a820, memtable=0x000000011854c7a0) at lsm_tree.cc:449:21 [opt] frame #7: 0x000000010137753f ep-engine_ep_unit_tests`magma::LSMTree::doMemtableFlushWork(this=0x000000011855a820) at lsm_tree.cc:531:18 [opt] frame #8: 0x000000010139fe62 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator()() [inlined] magma::LSMTree::newFlush(this=<unavailable>)::$_16::operator()() const at lsm_tree.cc:993:34 [opt] frame #9: 0x000000010139fe5d ep-engine_ep_unit_tests`std::__1::__function::__func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator()() [inlined] decltype(__f=<unavailable>)::$_16&>(fp)()) std::__1::__invoke<magma::LSMTree::newFlush()::$_16&>(magma::LSMTree::newFlush()::$_16&) at type_traits:3918:1 [opt] frame #10: 0x000000010139fe5d ep-engine_ep_unit_tests`std::__1::__function::__func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator()() [inlined] std::__1::tuple<magma::Status, magma::CheckpointTransaction> std::__1::__invoke_void_return_wrapper<std::__1::tuple<magma::Status, magma::CheckpointTransaction>, false>::__call<magma::LSMTree::newFlush(__args=<unavailable>)::$_16&>(magma::LSMTree::newFlush()::$_16&) at invoke.h:30:16 [opt] frame #11: 0x000000010139fe5d ep-engine_ep_unit_tests`std::__1::__function::__func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator()() [inlined] std::__1::__function::__alloc_func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator(this=<unavailable>)() at function.h:178:16 [opt] frame #12: 0x000000010139fe59 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::LSMTree::newFlush()::$_16, std::__1::allocator<magma::LSMTree::newFlush()::$_16>, std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator(this=<unavailable>)() at function.h:352:12 [opt] frame #13: 0x00000001012f72af ep-engine_ep_unit_tests`magma::FlushWork::Execute() [inlined] std::__1::__function::__value_func<std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator(this=<unavailable>)() const at function.h:505:16 [opt] frame #14: 0x00000001012f7296 ep-engine_ep_unit_tests`magma::FlushWork::Execute() [inlined] std::__1::function<std::__1::tuple<magma::Status, magma::CheckpointTransaction> ()>::operator(this=0x0000000118131560)() const at function.h:1182:12 [opt] frame #15: 0x00000001012f7292 ep-engine_ep_unit_tests`magma::FlushWork::Execute(this=0x0000000118131560) at flush_work.cc:61:29 [opt] frame #16: 0x0000000101389d5e ep-engine_ep_unit_tests`magma::KVStore::flushMemTables(this=0x00007ff7bfefe1c0)::$_38::operator()() at kvstore.cc:515:27 [opt] frame #17: 0x0000000101388fac ep-engine_ep_unit_tests`magma::KVStore::flushMemTables(this=0x000000010442a420, wal=<unavailable>, offset=(SegID = 1, SegOffset = 4096), flushMode=<unavailable>, blockMode=Blocking) at kvstore.cc:582:16 [opt] frame #18: 0x0000000101389a5a ep-engine_ep_unit_tests`magma::KVStore::FlushMemTables(this=<unavailable>, wal=<unavailable>, flushMode=<unavailable>, blockMode=<unavailable>) at kvstore.cc:387:12 [opt] frame #19: 0x00000001012fd9ba ep-engine_ep_unit_tests`magma::Magma::Impl::syncKVStore(this=0x000000011814f000, kvID=<unavailable>, checkpoint=true) at db.cc:1352:21 [opt] frame #20: 0x000000010132678a ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator()() [inlined] magma::Magma::Impl::CompactKVStore(this=0x00007ff7bfefe400)>)::$_7::operator()() const at db.cc:880:23 [opt] frame #21: 0x0000000101326772 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator()() [inlined] magma::Magma::Impl::CompactKVStore(this=<unavailable>)>)::$_8::operator()() const at db.cc:891:21 [opt] frame #22: 0x0000000101326772 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator()() [inlined] decltype(__f=<unavailable>)>)::$_8&>(fp)()) std::__1::__invoke<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8&>(magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8&) at type_traits:3918:1 [opt] frame #23: 0x0000000101326772 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator()() [inlined] void std::__1::__invoke_void_return_wrapper<void, true>::__call<magma::Magma::Impl::CompactKVStore(__args=<unavailable>)>)::$_8&>(magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8&) at invoke.h:61:9 [opt] frame #24: 0x0000000101326772 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator()() [inlined] std::__1::__function::__alloc_func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator(this=<unavailable>)() at function.h:178:16 [opt] frame #25: 0x0000000101326764 ep-engine_ep_unit_tests`std::__1::__function::__func<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8, std::__1::allocator<magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>)::$_8>, void ()>::operator(this=<unavailable>)() at function.h:352:12 [opt] frame #26: 0x0000000101303138 ep-engine_ep_unit_tests`magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>) [inlined] std::__1::__function::__value_func<void ()>::operator(this=<unavailable>)() const at function.h:505:16 [opt] frame #27: 0x000000010130312d ep-engine_ep_unit_tests`magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>) [inlined] std::__1::function<void ()>::operator(this=0x00007ff7bfefe4b0)() const at function.h:1182:12 [opt] frame #28: 0x0000000101303129 ep-engine_ep_unit_tests`magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>) [inlined] magma::defer::~defer(this=0x00007ff7bfefe4b0) at common.h:92:9 [opt] frame #29: 0x0000000101303129 ep-engine_ep_unit_tests`magma::Magma::Impl::CompactKVStore(unsigned short, magma::Slice const&, magma::Slice const&, std::__1::function<std::__1::unique_ptr<magma::Magma::CompactionCallback, std::__1::default_delete<magma::Magma::CompactionCallback> > (unsigned short)>) [inlined] magma::defer::~defer(this=0x00007ff7bfefe4b0) at common.h:91:14 [opt] frame #30: 0x0000000101303129 ep-engine_ep_unit_tests`magma::Magma::Impl::CompactKVStore(this=<unavailable>, kvID=<unavailable>, lowKey=0x00007ff7bfefe780, highKey=0x00007ff7bfefe780, makeCallback=magma::Magma::CompactionCallbackBuilder @ 0x00007ff7bfefe550)>) at db.cc:895:1 [opt] frame #31: 0x000000010130336c ep-engine_ep_unit_tests`magma::Magma::CompactKVStore(this=<unavailable>, kvID=0, lowKey=0x00007ff7bfefe780, highKey=<unavailable>, makeCallback=<unavailable>)>) at db.cc:901:18 [opt] frame #32: 0x000000010004fd3d ep-engine_ep_unit_tests`MagmaMemoryTrackingProxy::CompactKVStore(this=<unavailable>, kvID=0, lowKey=0x00007ff7bfefe780, highKey=0x00007ff7bfefe780, makeCallback=magma::Magma::CompactionCallbackBuilder @ 0x00007ff7bfefea00)>) at magma-memory-tracking-proxy.cc:190:19 [opt] frame #33: 0x00000001000a9eeb ep-engine_ep_unit_tests`MagmaKVStore::compactDBInternal(this=<unavailable>, vbLock=0x00007ff7bfefeda0, ctx=std::__1::shared_ptr<CompactionContext>::element_type @ 0x00000001184acc20 strong=3 weak=1) at magma-kvstore.cc:2590:29 [opt] frame #34: 0x00000001000a93ad ep-engine_ep_unit_tests`MagmaKVStore::compactDB(this=0x00000001067e6500, vbLock=0x00007ff7bfefeda0, ctx=nullptr) at magma-kvstore.cc:2445:12 [opt] frame #35: 0x00000001001d7eb0 ep-engine_ep_unit_tests`EPBucket::compactInternal(this=0x00000001067e6000, vb=0x00007ff7bfefed90, config=<unavailable>) at ep_bucket.cc:1398:25 [opt] frame #36: 0x00000001001d83f6 ep-engine_ep_unit_tests`EPBucket::doCompact(this=0x00000001067e6000, vbid=(vbid = 0), config=0x00007ff7bfefedf0, cookies=size=0) at ep_bucket.cc:1476:14 [opt] 3) Key sorting issue Magma now checks for sorted keys - it turns out KV flushing is violating that ordering. Need to know if KV should fix or is the magma check required?? Example: CollectionsDcpEphemeralOrPersistent/CollectionsLegacyDcpTest.default_collection_is_not_vbucket_highseqno_with_pending/persistent_nexus_couchstore_magma_value_only CRITICAL [(SynchronousEPEngine:default) magma_0]Fatal error: Found: preceding key(d2) > current key( _collection). If history is enabled, all keys in the batch must be sorted lexicographicall The problem is that the test flushes a prepare(default collection, key=d2) and create-collection(fruit) together. The flusher orders these... \0d2 \1create_fruit This is correct. But \0d2 is marked as a prepare, when flushed to disk it goes into a special namespace. This occurs in KVStore after the sorting. \0d2 becomes \2\0d2 And magma actually sees \2\0d2 \1create_fruit and we have violated the expects Change-Id: Ica9ea1b52c51f125c9e8839a0fca412834fc25f7
jimwwalker · Jan 23, 2023 · f95f2e7 · f95f2e7
1 parent 087b981
commit f95f2e7
Show file tree

Hide file tree

Showing 12 changed files with 316 additions and 87 deletions.
diff --git a/engines/ep/src/kv_bucket.cc b/engines/ep/src/kv_bucket.cc
@@ -3098,6 +3098,13 @@ std::chrono::seconds KVBucket::getHistoryRetentionSeconds() const {
 
 void KVBucket::setHistoryRetentionBytes(size_t bytes) {
  historyRetentionBytes = bytes;
+ for (auto& i : vbMap.shards) {
+ KVShard* shard = i.get();
+ // The KVStore needs to know the per vbucket size
+ shard->getRWUnderlying()->setHistoryRetentionBytes(bytes /
+ vbMap.getSize());
+ }
+
 }
 
 size_t KVBucket::getHistoryRetentionBytes() const {

diff --git a/engines/ep/src/kvstore/kvstore.h b/engines/ep/src/kvstore/kvstore.h
@@ -862,6 +862,13 @@ class KVStore : public KVStoreIface {
  */
  void checkIfInTransaction(Vbid vbid, std::string_view caller);
 
+ void setHistoryRetentionBytes(size_t size) override {
+ // no-op.
+ // Only supported by backends which report
+ // StorageProperties::HistoryRetentionAvailable::Yes
+ // For all other backends this function is allowed, but does nothing.
+ }
+
  /**
  * Check if the specified document metadata is /potentially/ affected
  * by a datatype corruption issue (MB-52793) - a deleted document with

diff --git a/engines/ep/src/kvstore/kvstore_iface.h b/engines/ep/src/kvstore/kvstore_iface.h
@@ -763,6 +763,11 @@ class KVStoreIface {
  * @param vbid ID of the vbucket being created
  */
  virtual void prepareToCreateImpl(Vbid vbid) = 0;
+
+ /**
+ * Method to configure the amount of history a vbucket should retain.
+ */
+ virtual void setHistoryRetentionBytes(size_t size) = 0;
 };
 
 std::string to_string(KVStoreIface::ReadVBStateStatus status);
diff --git a/engines/ep/src/kvstore/magma-kvstore/magma-kvstore.cc b/engines/ep/src/kvstore/magma-kvstore/magma-kvstore.cc
@@ -869,7 +869,7 @@ StorageProperties MagmaKVStore::getStorageProperties() const {
  StorageProperties::AutomaticDeduplication::No,
  StorageProperties::PrepareCounting::No,
  StorageProperties::CompactionStaleItemCallbacks::Yes,
- StorageProperties::HistoryRetentionAvailable::No);
+ StorageProperties::HistoryRetentionAvailable::Yes);
  return rv;
 }
 
@@ -1695,8 +1695,7 @@ std::unique_ptr<BySeqnoScanContext> MagmaKVStore::initBySeqnoScanContext(
  getDroppedStatus.String());
  }
 
- // @todo:assign this using magma->GetOldestHistorySeqno(snapshot);
- auto historyStartSeqno = 0;
+ auto historyStartSeqno = magma->GetOldestHistorySeqno(snapshot);
  if (logger->should_log(spdlog::level::info)) {
  logger->info(
  "MagmaKVStore::initBySeqnoScanContext {} seqno:{} endSeqno:{}"
@@ -1809,8 +1808,7 @@ std::unique_ptr<ByIdScanContext> MagmaKVStore::initByIdScanContext(
  return nullptr;
  }
 
- // @todo:assign this using magma->GetOldestHistorySeqno(snapshot);
- auto historyStartSeqno = 0;
+ auto historyStartSeqno = magma->GetOldestHistorySeqno(snapshot);
  logger->info(
  "MagmaKVStore::initByIdScanContext {} historyStartSeqno:{} "
  "KeyIterator:{}",
@@ -1830,13 +1828,16 @@ std::unique_ptr<ByIdScanContext> MagmaKVStore::initByIdScanContext(
  historyStartSeqno);
 }
 
+scan_error_t MagmaKVStore::scan(BySeqnoScanContext& ctx) const {
+ return scan(ctx, magma::Magma::SeqIterator::Mode::Snapshot);
+}
+
 scan_error_t MagmaKVStore::scanAllVersions(BySeqnoScanContext& ctx) const {
- // @todo use magma's mode
- // return scan(ctx, magma::Magma::SeqIterator::Mode::History);
- return scan(ctx);
+ return scan(ctx, magma::Magma::SeqIterator::Mode::History);
 }
 
-scan_error_t MagmaKVStore::scan(BySeqnoScanContext& ctx) const {
+scan_error_t MagmaKVStore::scan(BySeqnoScanContext& ctx,
+ magma::Magma::SeqIterator::Mode mode) const {
  if (ctx.lastReadSeqno == ctx.maxSeqno) {
  logger->TRACE("MagmaKVStore::scan {} lastReadSeqno:{} == maxSeqno:{}",
  ctx.vbid,
@@ -1849,7 +1850,8 @@ scan_error_t MagmaKVStore::scan(BySeqnoScanContext& ctx) const {
  startSeqno = ctx.lastReadSeqno + 1;
  }
  auto& mctx = dynamic_cast<MagmaScanContext&>(ctx);
- for (mctx.itr->Seek(startSeqno, ctx.maxSeqno); mctx.itr->Valid();
+ for (mctx.itr->Initialize(startSeqno, ctx.maxSeqno, mode);
+ mctx.itr->Valid();
  mctx.itr->Next()) {
  Slice keySlice, metaSlice, valSlice;
  uint64_t seqno;
@@ -3722,3 +3724,7 @@ std::pair<Status, uint64_t> MagmaKVStore::getOldestRollbackableHighSeqno(
 
  return {status, seqno};
 }
+
+void MagmaKVStore::setHistoryRetentionBytes(size_t size) {
+ magma->SetHistoryRetentionSize(size);
+}
diff --git a/engines/ep/src/kvstore/magma-kvstore/magma-kvstore.h b/engines/ep/src/kvstore/magma-kvstore/magma-kvstore.h
@@ -568,6 +568,12 @@ class MagmaKVStore : public KVStore {
  std::unique_ptr<TransactionContext> begin(
  Vbid vbid, std::unique_ptr<PersistenceCallback> pcb) override;
 
+ /**
+ * Informs magma of how much history must be retained using
+ * Magma::SetHistoryRetentionTime
+ */
+ void setHistoryRetentionBytes(size_t size) override;
+
  // Magma uses a unique logger with a prefix of magma so that all logging
  // calls from the wrapper thru magma will be prefixed with magma.
  std::shared_ptr<BucketLogger> logger;
@@ -782,6 +788,9 @@ class MagmaKVStore : public KVStore {
  folly::assume_unreachable();
  }
 
+ scan_error_t scan(BySeqnoScanContext& ctx,
+ magma::Magma::SeqIterator::Mode mode) const;
+
  MagmaKVStoreConfig& configuration;
 
  /**

diff --git a/engines/ep/src/kvstore/nexus-kvstore/nexus-kvstore.h b/engines/ep/src/kvstore/nexus-kvstore/nexus-kvstore.h
@@ -143,6 +143,9 @@ class NexusKVStore : public KVStoreIface {
  void delSystemEvent(TransactionContext& txnCtx,
  const queued_item item) override;
  void endTransaction(Vbid vbid) override;
+ void setHistoryRetentionBytes(size_t size) override {
+ // not supported on Nexus
+ }
 
  /**
  * Unit test only hook called before we compact the first KVStore. Public as

diff --git a/engines/ep/tests/mock/mock_kvstore.h b/engines/ep/tests/mock/mock_kvstore.h
@@ -225,6 +225,7 @@ class MockKVStore : public KVStore {
  prepareToRollback,
  (Vbid vbid),
  (override));
+ MOCK_METHOD(void, setHistoryRetentionBytes, (size_t size), (override));
 
  /**
  * Helper function to replace the existing read-write KVStore in the given

diff --git a/engines/ep/tests/module_tests/collections/collections_dcp_test.h b/engines/ep/tests/module_tests/collections/collections_dcp_test.h
@@ -103,17 +103,27 @@ class CollectionsDcpTest : virtual public SingleThreadedKVBucketTest {
  const CollectionEntry::Entry& entry,
  uint64_t seqno);
 
+ /**
+ * This function (created for OSO tests) creates two collections (fruit
+ * and vegetable) and calls writeTwoCollections
+ *
+ * @param endOnVegetable true and the last item written will be for the
+ * vegetable collection
+ * @return current manifest and vbucket (::vbid) high-seqno
+ */
+ std::pair<CollectionsManifest, uint64_t> setupTwoCollections(
+ bool endOnVegetable = false);
+
  /**
  * This function (created for OSO tests) writes to two collections (fruit
  * and vegetable). The keys are "a", "b", "c" and "d" to demonstrate the
  * lexicographical ordering of an OSO snapshot.
  *
  * @param endOnVegetable true and the last item written will be for the
- *  vegetable collection
- * @return manifest and high-seqno
+ * vegetable collection
+ * @return vbucket (::vbid) high-seqno
  */
- std::pair<CollectionsManifest, uint64_t> setupTwoCollections(
- bool endOnVegetable = false);
+ uint64_t writeTwoCollectios(bool endOnTarget);
 
  static cb::engine_errc dcpAddFailoverLog(
  const std::vector<vbucket_failover_t>&);

diff --git a/engines/ep/tests/module_tests/collections/collections_kvstore_test.cc b/engines/ep/tests/module_tests/collections/collections_kvstore_test.cc
@@ -92,7 +92,8 @@ class CollectionsKVStoreTestBase : public KVStoreBackend, public KVStoreTest {
 
  void applyEvents(TransactionContext& txnCtx,
  VB::Commit& commitData,
- const CollectionsManifest& cm) {
+ const CollectionsManifest& cm,
+ bool writeEventNow = true) {
  manifest.update(*vbucket, makeManifest(cm));
 
  std::vector<queued_item> events;
@@ -101,17 +102,44 @@ class CollectionsKVStoreTestBase : public KVStoreBackend, public KVStoreTest {
 
  for (auto& ev : events) {
  commitData.collections.recordSystemEvent(*ev);
+ if (writeEventNow) {
+ if (ev->isDeleted()) {
+ kvstore->delSystemEvent(txnCtx, ev);
+ } else {
+ kvstore->setSystemEvent(txnCtx, ev);
+ }
+ }
+ }
+ if (!writeEventNow) {
+ std::move(events.begin(),
+ events.end(),
+ std::back_inserter(allEvents));
+ }
+ }
+
+ void applyEvents(TransactionContext& txnCtx,
+ const CollectionsManifest& cm,
+ bool writeEventNow = true) {
+ return applyEvents(txnCtx, flush, cm, writeEventNow);
+ }
+
+ // This function is to be used in conjunction with applyEvents when
+ // writeEventNow=false allowing a test to better emulate the flusher and
+ // write keys in a sorted batch. Tests can applyEvents so that collection
+ // metadata management does updates, but defer the system event writing
+ // until ready to commit
+ void sortAndWriteAllEvents(TransactionContext& txnCtx) {
+ std::sort(allEvents.begin(),
+ allEvents.end(),
+ OrderItemsForDeDuplication{});
+ for (auto& ev : allEvents) {
  if (ev->isDeleted()) {
  kvstore->delSystemEvent(txnCtx, ev);
  } else {
  kvstore->setSystemEvent(txnCtx, ev);
  }
  }
- }
-
- void applyEvents(TransactionContext& txnCtx,
- const CollectionsManifest& cm) {
- applyEvents(txnCtx, flush, cm);
+ allEvents.clear();
  }
 
  void checkUid(const Collections::KVStore::Manifest& md,
@@ -224,7 +252,8 @@ class CollectionsKVStoreTestBase : public KVStoreBackend, public KVStoreTest {
  VB::Commit commitData(manifest);
  auto ctx = kvstore->begin(vbucket->getId(),
  std::make_unique<PersistenceCallback>());
- applyEvents(*ctx, commitData, cm);
+ applyEvents(*ctx, commitData, cm, false);
+ sortAndWriteAllEvents(*ctx);
  kvstore->commit(std::move(ctx), commitData);
  auto [status, md] = kvstore->getCollectionsManifest(Vbid(0));
  EXPECT_TRUE(status);
@@ -240,6 +269,7 @@ class CollectionsKVStoreTestBase : public KVStoreBackend, public KVStoreTest {
  VBucketPtr vbucket;
  WriteCallback wc;
  DeleteCallback dc;
+ std::vector<queued_item> allEvents;
 };
 
 class CollectionsKVStoreTest
@@ -583,19 +613,21 @@ class CollectionRessurectionKVStoreTest
  auto ctx = kvstore->begin(vbucket->getId(),
  std::make_unique<PersistenceCallback>());
  cm.add(targetScope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  cm.add(target, targetScope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
+ sortAndWriteAllEvents(*ctx);
  kvstore->commit(std::move(ctx), flush);
  }
 
  // runs a flush batch that will leave the target collection in dropped state
  void dropScope() {
  openScopeOpenCollection();
- cm.remove(targetScope);
  auto ctx = kvstore->begin(vbucket->getId(),
  std::make_unique<PersistenceCallback>());
- applyEvents(*ctx, cm);
+ cm.remove(targetScope);
+ applyEvents(*ctx, cm, false);
+ sortAndWriteAllEvents(*ctx);
  kvstore->commit(std::move(ctx), flush);
  }
 
@@ -709,9 +741,9 @@ void CollectionRessurectionKVStoreTest::resurectionScopesTest() {
  std::make_unique<PersistenceCallback>());
  if (!cm.exists(targetScope)) {
  cm.add(targetScope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  cm.add(target, targetScope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  }
 
  std::string expectedName = target.name;
@@ -720,22 +752,23 @@ void CollectionRessurectionKVStoreTest::resurectionScopesTest() {
  // iterate cycles of remove/add
  for (int ii = 0; ii < getCycles(); ii++) {
  cm.remove(scope);
- applyEvents(*ctx, cm);
-
+ applyEvents(*ctx, cm, false);
  if (resurectWithNewName()) {
  expectedName = target.name + "_" + std::to_string(ii);
  scope.name = targetScope.name + "_" + std::to_string(ii);
  }
  cm.add(scope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  cm.add({expectedName, target.uid}, scope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  }
 
  if (dropCollectionAtEnd()) {
  cm.remove(scope);
- applyEvents(*ctx, cm);
+ applyEvents(*ctx, cm, false);
  }
+
+ sortAndWriteAllEvents(*ctx);
  kvstore->commit(std::move(ctx), flush);
 
  // Now validate

diff --git a/engines/ep/tests/module_tests/collections/collections_oso_dcp_test.cc b/engines/ep/tests/module_tests/collections/collections_oso_dcp_test.cc
@@ -45,11 +45,15 @@ class CollectionsOSODcpTest : public CollectionsDcpParameterizedTest {
 
 std::pair<CollectionsManifest, uint64_t>
 CollectionsDcpTest::setupTwoCollections(bool endOnTarget) {
- VBucketPtr vb = store->getVBucket(vbid);
  CollectionsManifest cm(CollectionEntry::fruit);
  setCollections(cookie, cm.add(CollectionEntry::vegetable));
+ flush_vbucket_to_disk(vbid, 2);
+ return {cm, writeTwoCollectios(endOnTarget)};
+}
 
- // Interleave the writes to two collections and then OSO backfill one
+uint64_t CollectionsDcpTest::writeTwoCollectios(bool endOnTarget) {
+ // Interleave the writes to two collections, this is linked to expectations
+ // in CollectionsOSODcpTest test harness
  store_item(vbid, makeStoredDocKey("b", CollectionEntry::fruit), "q");
  store_item(vbid, makeStoredDocKey("b", CollectionEntry::vegetable), "q");
  store_item(vbid, makeStoredDocKey("d", CollectionEntry::fruit), "a");
@@ -66,8 +70,8 @@ CollectionsDcpTest::setupTwoCollections(bool endOnTarget) {
  vbid, makeStoredDocKey("c", CollectionEntry::vegetable), "q");
  store_item(vbid, makeStoredDocKey("c", CollectionEntry::fruit), "y");
  }
- flush_vbucket_to_disk(vbid, 10); // 8 keys + 2 events
- return {cm, vb->getHighSeqno()};
+ flush_vbucket_to_disk(vbid, 8);
+ return store->getVBucket(vbid)->getHighSeqno();
 }
 
 // Run through how we expect OSO to work, this is a minimal test which will
@@ -674,7 +678,6 @@ TEST_P(CollectionsOSODcpTest, MB_43700) {
 // snapshots
 class CollectionsOSOEphemeralTest : public CollectionsDcpParameterizedTest {
 public:
- std::pair<CollectionsManifest, uint64_t> setupTwoCollections();
 };
 
 // Run through how we expect OSO to work, this is a minimal test which will