Merge pull request #16 from jimmyale3102/dev

Dev
jimmyale3102 · Nov 7, 2024 · ce2b699 · ce2b699
2 parents b5a3fd1 + 2959e4d
commit ce2b699
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/public/share/Jimmy_Plazas_Resume.pdf → public/share/CV.pdf b/public/share/Jimmy_Plazas_Resume.pdf → public/share/CV.pdf
diff --git a/src/components/common/IconButtonComponent.js b/src/components/common/IconButtonComponent.js
@@ -2,7 +2,7 @@ import React from 'react';
 import { useTheme, IconButton, Typography } from '@mui/material';
 import { BorderRadiusMedium, onLightIconColor, onDarkIconColor } from '../../ThemeContext';
 
-function IconButtonComponent({text = '', href, IconComponent}) {
+function IconButtonComponent({ text = '', href, IconComponent }) {
   const theme = useTheme();
   const iconColor = theme.palette.mode === 'light' ? onLightIconColor : onDarkIconColor;
 
@@ -13,9 +13,13 @@ function IconButtonComponent({text = '', href, IconComponent}) {
         onClick={() => window.open(href, '_blank')}
       >
         <IconComponent style={{ fill: iconColor }} />
-        <Typography paddingLeft={'8px'} variant="body2" color="text.secondary" alignSelf={'center'}>
-          {text}
-        </Typography>
+        {
+          text ? (
+            <Typography paddingLeft={'8px'} variant="body2" color="text.secondary" alignSelf={'center'}>
+              {text}
+            </Typography>
+          ) : null
+        }
       </IconButton>
     ) : null
   );

diff --git a/src/components/home/videoItem.js b/src/components/home/videoItem.js
@@ -24,7 +24,7 @@ function VideoItem({ videoId, title, description, videoAlt, url }) {
           <Grid container spacing={2} alignItems={"top"} style={{display: 'flex'}}>
             <Grid item xs={12} sm={6}>
               <lite-youtube
-                style={{ width: '100%', height: 'auto', maxWidth: '560px', maxHeight: '315px' }}
+                style={{ width: '100%', height: 'auto', maxWidth: '560px', maxHeight: '315px', borderRadius: BorderRadiusCard }}
                 videoid={videoId}
               />
             </Grid>

diff --git a/src/sections/app/Footer.js b/src/sections/app/Footer.js
@@ -31,7 +31,11 @@ function Footer() {
           <IconButtonComponent href='https://www.youtube.com/@jimmy_code/videos' IconComponent={YouTubeIcon} />
           <IconButtonComponent href='mailto:[email protected]' IconComponent={Email} />
         </Box>
-        <Typography variant="body2" fontStyle={'italic'} style={{ justifyContent: 'center', textAlign: 'center', display: 'flex', alignItems: 'center' }}>
+        <Typography
+          margin={MarginDefault}
+          variant="body2"
+          fontStyle={'italic'}
+          style={{ justifyContent: 'center', textAlign: 'center', display: 'flex', alignItems: 'center' }}>
           Made with
           <Favorite style={{ width: '18px', height: '18px', fill: iconColor, marginInline: MarginXSmall }} />
           by Jimmy.

diff --git a/src/sections/home/Intro.js b/src/sections/home/Intro.js
@@ -79,7 +79,7 @@ function Intro() {
                     color: iconColor,
                     border: `1px solid ${borderColor}`
                   }}
-                  href='./share/Jimmy_Plazas_Resume.pdf'
+                  href='./share/CV.pdf'
                   target='_blank'>
                   <ResumeIcon style={{ width: '18px', height: '18px', marginRight: MarginXSmall, fill: iconColor }} />
                   Resume