ci_build.sh: comment "default-all-errors" builds with varying SSL imp…

…lementations and refactor into a loop and case

Should be helftul for networkupstools/jenkins-dynamatrix#4 eventually

ci_build.sh

@@ -521,27 +521,84 @@ default|default-alldrv|default-all-errors|default-spellcheck|default-shellcheck|
             exit $?
             ;;
         "default-all-errors")
+            # Try to run various build scenarios to collect build errors
+            # (no checks here) as configured further by caller's choice
+            # of BUILD_WARNFATAL and/or BUILD_WARNOPT envvars above.
+            # Note this is one scenario where we did not configure_nut()
+            # in advance.
             RES=0
-            if pkg-config --exists nss && pkg-config --exists openssl && [ "${BUILD_SSL_ONCE-}" != "true" ] ; then
-                # Try builds for both cases as they are ifdef-ed
+            FAILED=""
+            SUCCEEDED=""
+
+            # Technically, let caller provide this setting explicitly
+            if [ -z "$NUT_SSL_VARIANTS" ] ; then
+                NUT_SSL_VARIANTS="auto"
+                if pkg-config --exists nss && pkg-config --exists openssl && [ "${BUILD_SSL_ONCE-}" != "true" ] ; then
+                    # Try builds for both cases as they are ifdef-ed
+                    # TODO: Extend if we begin to care about different
+                    # major versions of openssl (with their APIs), etc.
+                    NUT_SSL_VARIANTS="openssl nss"
+                else
+                    if [ "${BUILD_SSL_ONCE-}" != "true" ]; then
+                        pkg-config --exists nss 2>/dev/null && NUT_SSL_VARIANTS="nss"
+                        pkg-config --exists openssl 2>/dev/null && NUT_SSL_VARIANTS="openssl"
+                    fi  # else leave at "auto", if we skipped building
+                        # two variants while having two possibilities
+                fi
 
-                echo "=== Building with SSL=openssl..."
-                ( CONFIG_OPTS+=("--with-openssl")
-                  configure_nut
-                  build_to_only_catch_errors ) || RES=$?
+                # Consider also a build --without-ssl to test that codepath?
+                if [ "$NUT_SSL_VARIANTS" != auto ] && [ "${BUILD_SSL_ONCE-}" != "true" ]; then
+                    NUT_SSL_VARIANTS="$NUT_SSL_VARIANTS no"
+                fi
+            fi
 
+            for NUT_SSL_VARIANT in $NUT_SSL_VARIANTS ; do
                 echo "=== Clean the sandbox..."
                 $MAKE distclean -k || true
 
-                echo "=== Building with SSL=nss..."
-                ( CONFIG_OPTS+=("--with-nss")
-                  configure_nut
-                  build_to_only_catch_errors ) || RES=$?
-            else
-                # Build what we can configure
-                configure_nut
-                build_to_only_catch_errors || RES=$?
+                case "$NUT_SSL_VARIANT" in
+                    ""|auto|default)
+                        # Quietly build one scenario, whatever we can (or not)
+                        # configure regarding SSL and other features
+                        NUT_SSL_VARIANT=auto
+                        configure_nut
+                        ;;
+                    no)
+                        echo "=== Building without SSL support..."
+                        ( CONFIG_OPTS+=("--without-ssl")
+                          configure_nut
+                        )
+                        ;;
+                    *)
+                        echo "=== Building with NUT_SSL_VARIANT='${NUT_SSL_VARIANT}' ..."
+                        ( CONFIG_OPTS+=("--with-${NUT_SSL_VARIANT}")
+                          configure_nut
+                        )
+                        ;;
+                esac || {
+                    RES=$?
+                    FAILED="${FAILED} NUT_SSL_VARIANT=${NUT_SSL_VARIANT}[configure]"
+                    continue
+                }
+
+                build_to_only_catch_errors && {
+                    SUCCEEDED="${SUCCEEDED} NUT_SSL_VARIANT=${NUT_SSL_VARIANT}"
+                } || {
+                    RES=$?
+                    FAILED="${FAILED} NUT_SSL_VARIANT=${NUT_SSL_VARIANT}[build]"
+                }
+            done
+            # TODO: Similar loops for other variations like TESTING,
+            # MGE SHUT vs other serial protocols, libusb version...
+
+            if [ -n "$SUCCEEDED" ]; then
+                echo "SUCCEEDED build(s) with:${SUCCEEDED}" >&2
             fi
+            if [ "$RES" != 0 ]; then
+                # Leading space is included in FAILED
+                echo "FAILED build(s) with:${FAILED}" >&2
+            fi
+
             exit $RES
             ;;
     esac