tools/nut-scanner/scan_xml_http.c: close broadcast socket too, avoid …

…FD leak [networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
jimklimov · Jul 11, 2024 · 74a1378 · 74a1378
1 parent 5ce752c
commit 74a1378
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/tools/nut-scanner/scan_xml_http.c b/tools/nut-scanner/scan_xml_http.c
@@ -217,7 +217,7 @@ static void * nutscan_scan_xml_http_thready(void * arg)
 /* A NULL "ip" causes a broadcast scan; otherwise the single ip address is queried directly */
 	char *ip = NULL;
 	useconds_t usec_timeout = 0;
-	int peerSocket;
+	int peerSocket = -1;
 	int sockopt_on = 1;
 	struct sockaddr_in sockAddress_udp;
 	socklen_t sockAddressLength = sizeof(sockAddress_udp);
@@ -433,7 +433,8 @@ static void * nutscan_scan_xml_http_thready(void * arg)
 		(ip ? ip : "<broadcast>"));
 
 end:
-	if (ip != NULL)
+	/* Broadcast is also a socket! */
+	if (peerSocket != -1)
 		close(peerSocket);
 
 end_free: