fix sort builder rewrite

jimczi · Oct 8, 2024 · 84fe337 · 84fe337
1 parent 7e4e1d3
commit 84fe337
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/search/retriever/StandardRetrieverBuilder.java b/server/src/main/java/org/elasticsearch/search/retriever/StandardRetrieverBuilder.java
@@ -125,7 +125,9 @@ public RetrieverBuilder rewrite(QueryRewriteContext ctx) throws IOException {
         if (sortBuilders != null) {
             newSortBuilders = new ArrayList<>(sortBuilders.size());
             for (var sort : sortBuilders) {
-                changed |= newSortBuilders.add(sort.rewrite(ctx));
+                var newSort = sort.rewrite(ctx);
+                newSortBuilders.add(newSort);
+                changed = newSort != sort;
             }
         }
         var rewrittenFilters = rewritePreFilters(ctx);