minor fixes

jimczi · Jun 21, 2024 · 7ca753b · 7ca753b
1 parent 6d52379
commit 7ca753b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/search/retriever/RankDocsQueryBuilder.java b/server/src/main/java/org/elasticsearch/search/retriever/RankDocsQueryBuilder.java
@@ -78,13 +78,15 @@ private static int[] findSegmentStarts(IndexReader reader, RankDoc[] docs) {
 
     @Override
     protected void doXContent(XContentBuilder builder, Params params) throws IOException {
+        builder.startObject(NAME);
         builder.startArray("docs");
         for (RankDoc doc : rankDocs) {
             builder.startObject();
             doc.toXContent(builder, params);
             builder.endObject();
         }
         builder.endArray();
+        builder.endObject();
     }
 
     @Override

diff --git a/server/src/main/java/org/elasticsearch/search/retriever/RankDocsRetrieverBuilder.java b/server/src/main/java/org/elasticsearch/search/retriever/RankDocsRetrieverBuilder.java
@@ -10,6 +10,7 @@
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.common.Strings;
 import org.elasticsearch.index.query.BoolQueryBuilder;
 import org.elasticsearch.index.query.DisMaxQueryBuilder;
 import org.elasticsearch.index.query.QueryBuilder;

diff --git a/server/src/main/java/org/elasticsearch/search/retriever/RetrieverBuilder.java b/server/src/main/java/org/elasticsearch/search/retriever/RetrieverBuilder.java
@@ -203,7 +203,8 @@ public RetrieverBuilder rewrite(QueryRewriteContext ctx) throws IOException {
     public abstract QueryBuilder topDocsQuery();
 
     /**
-     * Called by {@link CombineRetrieverBuilder} to seal the top docs returned by this retriever.
+     * This function is called by {@link CombineRetrieverBuilder}s to seal the top docs returned by
+     * this retriever during rewrite.
      */
     public void setRankDocs(RankDoc[] rankDocs) {
         this.rankDocs = rankDocs;