Skip to content

Commit

Permalink
update 1.16.1 - patch for #163
Browse files Browse the repository at this point in the history
  • Loading branch information
irfan-dahir committed Jul 2, 2018
1 parent aa56b14 commit cdfc9cf
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 13 deletions.
8 changes: 8 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
## Changelog

### 1.16.1 stable - July 3, 17
- Bug fix [#163](/../../issues/163)

### 1.16.0 stable - June 28, 17
- Switch over to Guzzle for fetching file/status
- Improvements to Search, Seasonal & Person by extending the schema
- Fix some parsing issues with some requests depending on geolocation thinking

### 1.15.14 stable - May 26, 18
- **[Anime, Manga, Extended]**
- Fix Some parsing methods were not parsing correctly [#148](/../../issues/148)
Expand Down
2 changes: 1 addition & 1 deletion examples/test.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
$time_start = microtime(true);

// $jikan->Manga(1, [CHARACTERS]);
$jikan->Search("Grand%20Blue", MANGA);
$jikan->Manga(1, [CHARACTERS]);
// $jikan->Seasonal();

$time_end = microtime(true);
Expand Down
9 changes: 2 additions & 7 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,8 @@ Contributions to Jikan by making wrappers in programming languages of your choic
- [PThreads](https://github.com/krakjoe/pthreads) (Multi-threaded) Support (CLI ONLY!)

## Changelog
### 1.15.14 stable - May 26, 18
- **[Anime, Manga, Extended]**
- Fix Some parsing methods were not parsing correctly [#148](/../../issues/148)
- **[Person]**
- Add information about roles [#146](/../../issues/146)
- **[Seasonal]**
- Add `season_name` and `season_year` data
### 1.16.1 stable - July 3, 17
- Bug fix [#163](/../../issues/163)

**[Read More](https://github.com/jikan-me/jikan/tree/master/changelog.md)**

Expand Down
2 changes: 1 addition & 1 deletion src/Lib/Parser/AnimeCharacterStaffParse.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function parse(): Array

$this->addRule(
'character',
'~</div>Characters & Voice Actors</h2>~',
'~<h2>Characters & Voice Actors</h2>~',
function () {
$running = true;
$i = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/Lib/Parser/MangaCharacterParse.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function parse(): Array

$this->addRule(
'character',
'~</div>Characters</h2>~',
'~<h2>Characters</h2>~',
function () {
$running = true;
$i = 0;
Expand Down
7 changes: 4 additions & 3 deletions src/Lib/Parser/PersonParse.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ function () {

$this->addRule(
'voice_acting_role',
'~</div>Voice Acting Roles</div>~',
'~<div class="normal_header">Voice Acting Roles</div>~',
function () {
$running = true;
$i = 1;
$voiceActingRoles = [];
while ($running) {
$line = $this->file[$this->lineNo + $i];
if (preg_match('~</span>Anime Staff Positions</div>~', $line)) {
if (preg_match('~<div class="normal_header">Anime Staff Positions</div>~', $line)) {
$running = false;
}

Expand All @@ -175,6 +175,7 @@ function () {
$this->file[$this->lineNo + $i],
$char
);

$i++;
$charMeta = [];
preg_match(
Expand Down Expand Up @@ -208,7 +209,7 @@ function () {

$this->addRule(
'anime_staff_position',
'~</span>Anime Staff Positions</div>~',
'~<div class="normal_header">Anime Staff Positions</div>~',
function () {
$running = true;
$i = 1;
Expand Down

0 comments on commit cdfc9cf

Please sign in to comment.