skip VCR for tests that create bigtable instance (GoogleCloudPlatform…

…#9369)
jialei-chen · Nov 29, 2023 · b358749 · b358749
1 parent 432530c
commit b358749
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/mmv1/products/bigtable/AppProfile.yaml b/mmv1/products/bigtable/AppProfile.yaml
@@ -43,6 +43,8 @@ examples:
       deletion_protection: 'false'
     ignore_read_extra:
       - 'ignore_warnings'
+    # bigtable instance does not use the shared HTTP client, this test creates an instance
+    skip_vcr: true
   - !ruby/object:Provider::Terraform::Examples
     name: 'bigtable_app_profile_singlecluster'
     primary_resource_id: 'ap'
@@ -56,6 +58,8 @@ examples:
       deletion_protection: 'false'
     ignore_read_extra:
       - 'ignore_warnings'
+    # bigtable instance does not use the shared HTTP client, this test creates an instance
+    skip_vcr: true
   - !ruby/object:Provider::Terraform::Examples
     name: 'bigtable_app_profile_multicluster'
     primary_resource_id: 'ap'
@@ -69,6 +73,8 @@ examples:
       deletion_protection: 'false'
     ignore_read_extra:
       - 'ignore_warnings'
+    # bigtable instance does not use the shared HTTP client, this test creates an instance
+    skip_vcr: true
 custom_code: !ruby/object:Provider::Terraform::CustomCode
   encoder: templates/terraform/encoders/bigtable_app_profile.go.erb
   extra_schema_entry: templates/terraform/extra_schema_entry/bigtable_app_profile.go.erb

diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go
@@ -1057,6 +1057,8 @@ func TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines(t
 }
 
 func TestAccBigQueryDataTable_bigtable(t *testing.T) {
+	// bigtable instance does not use the shared HTTP client, this test creates an instance
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{

diff --git a/mmv1/third_party/terraform/services/bigtable/resource_bigtable_gc_policy_test.go b/mmv1/third_party/terraform/services/bigtable/resource_bigtable_gc_policy_test.go
@@ -166,6 +166,7 @@ func TestAccBigtableGCPolicy_multiplePolicies(t *testing.T) {
 }
 
 func TestAccBigtableGCPolicy_gcRulesPolicy(t *testing.T) {
+	// bigtable instance does not use the shared HTTP client, this test creates an instance
 	acctest.SkipIfVcr(t)
 	t.Parallel()