Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr template #128

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Pr template #128

merged 2 commits into from
Apr 8, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Apr 5, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

This PR mimics the one for OTTR_Template, adding a PR Template specific to adding a course to the sync.yml for this repo.

What was your approach?

Like the linked PR, this one

  • Creates a new subdirectory PULL_REQUEST_TEMPLATE within the .github directory
  • Moves the pre-existing PR template into that subdirectory (renaming the file to pull_request_template_general.md and adding a header)
  • Creates a new PR template (add_to_sync_template.md) within the subdirectory with a header that automatically assigns Candace and explains that sync.yml is being edited to enroll a new repository in OTTR updates
  • Adds the new template to list of documents that get cleaned up in downstream repos within the .github/workflows/starting-course.yml file because we don't want downstream repos to create issues that assign Candace for review

@kweav kweav requested a review from cansavvy April 5, 2024 19:41
Copy link
Collaborator

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cansavvy cansavvy merged commit e87c706 into main Apr 8, 2024
4 of 5 checks passed
@cansavvy cansavvy deleted the pr_template branch April 8, 2024 17:47
Copy link

github-actions bot commented Apr 9, 2024

The broken url errors check is currently being re-run 🏃
Comment updated at 2024-04-09-21:31:37 with changes from 81fc39d

Copy link

github-actions bot commented Apr 9, 2024

The spelling errors check is currently being re-run 🏃
Comment updated at 2024-04-09-21:31:38 with changes from 81fc39d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants