Improve handling of 'op' in __richcmp__ in coxter.pyx

jhpalmieri · Aug 5, 2023 · c11b4f6 · c11b4f6
1 parent 21ce8b6
commit c11b4f6
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/sage/libs/coxeter3/coxeter.pyx b/src/sage/libs/coxeter3/coxeter.pyx
@@ -87,7 +87,9 @@ cdef class String:
             True
         """
         if type(other) is not type(self):
-            return False
+            if op in (Py_LT, Py_LE, Py_GT, Py_GE):
+                return NotImplemented
+            return op == Py_NE
 
         s = repr(self)
         o = repr(other)
@@ -200,7 +202,9 @@ cdef class Type:
             True
         """
         if type(other) is not type(self):
-            return False
+            if op in (Py_LT, Py_LE, Py_GT, Py_GE):
+                return NotImplemented
+            return op == Py_NE
 
         s = repr(self)
         o = repr(other)
@@ -364,7 +368,9 @@ cdef class CoxGroup(SageObject):
             True
         """
         if type(other) is not type(self):
-            return False
+            if op in (Py_LT, Py_LE, Py_GT, Py_GE):
+                return NotImplemented
+            return op == Py_NE
 
         s_t = self.type()
         o_t = other.type()
@@ -840,7 +846,9 @@ cdef class CoxGroupElement:
             True
         """
         if type(other) is not type(self):
-            return False
+            if op in (Py_LT, Py_LE, Py_GT, Py_GE):
+                return NotImplemented
+            return op == Py_NE
 
         s_p = self.parent_group()
         o_p = other.parent_group()